Uh oh!
There was an error while loading. Please reload this page.
Upgrade wagtail to 3.x - #2934
Merged
Merged
Conversation
theskumarforce-pushed
the
maintenance/theskumar/update-wagtail-3
branch
from
July 22, 2022 06:31
a86795c to
70fbccfCompareCodecov Report
@@ Coverage Diff @@## main #2934 +/- ##
==========================================
+ Coverage 81.89% 81.96% +0.07%
==========================================
Files 683 704 +21 Lines 24809 24950 +141 ==========================================
+ Hits 20317 20450 +133 - Misses 4492 4500 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
theskumar
marked this pull request as ready for review
July 25, 2022 05:32
theskumarforce-pushed
the
maintenance/theskumar/update-wagtail-3
branch
2 times, most recently
from
July 25, 2022 09:36
8cb8ca5 to
e822419Comparetheskumarforce-pushed
the
maintenance/update-wagtail-3
branch
from
July 25, 2022 09:37
36c2e89 to
fe7f442CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
theskumar
marked this pull request as draft
July 26, 2022 09:45
Closed
theskumarforce-pushed
the
maintenance/theskumar/update-wagtail-3
branch
from
July 28, 2022 08:20
af43f16 to
b923832Comparetheskumar
marked this pull request as ready for review
July 28, 2022 10:22
theskumar
commented
Jul 28, 2022
MemberAuthor
The test_add_screening_status is failing for me locally. The reason seems to be there is no pre-defined ordering on the tables, but you are expecting an
I’m not sure how it’s passing in the circle CI, but it’s failing on my machine. @frjo@sandeepsajan0 |
theskumarforce-pushed
the
maintenance/theskumar/update-wagtail-3
branch
from
July 28, 2022 10:29
95317a0 to
2361652CompareChangelog: wagtail/wagtail-factories@2.0.1...2.1.0 2.1.0 ===== - Add support for Wagtail 3.0 and drop support for all Wagtail versions before 2.15 - Add support for Django 4.0 - Add support for Python 3.10 - Removed support for Python 3.6 - Removed support for Django 2.2 and 3.1 - Removed support for factory boy <3.2
Do not depend on sorting IDs for checks
Use `django.test.TestCase` instead of `unittest.TestCase` to enable DB access
See: https://django-filter.readthedocs.io/en/stable/guide/migration.html#view-attributes-renamed-867 ``` hypha/apply/api/v1/screening/tests/test_views.py::ScreeningStatusViewSetTests::test_staff_can_list_screening_statuses hypha/apply/api/v1/screening/tests/test_views.py::ScreeningStatusViewSetTests::test_staff_can_view_screening_statuses_detail /Users/theskumar/work/hyphaapp/hypha/venv/lib/python3.9/site-packages/django_filters/rest_framework/backends.py:31: MigrationNotice: `ScreeningStatusViewSet.filter_class` attribute should be renamed `filterset_class`. See: https://django-filter.readthedocs.io/en/master/guide/migration.html See: https://django-filter.readthedocs.io/en/master/guide/migration.html filterset_class = self.get_filterset_class(view, queryset) ```
…ed in favor of {% if %}
```
hypha/apply/determinations/tests/test_views.py: 20 warnings
/Users/theskumar/work/hyphaapp/hypha/venv/lib/python3.9/site-packages/django/template/defaulttags.py:862: RemovedInDjango40Warning: The {% ifequal %} template tag is deprecated in favor of {% if %}.
warnings.warn(
```frjoforce-pushed
the
maintenance/theskumar/update-wagtail-3
branch
from
August 1, 2022 12:36
2361652 to
dc5c948Comparefrjo
approved these changes
Aug 1, 2022
Related to #2882 The messaging.py has quite a lot of code with multiple concerns, which can be easily divided into individual independent modules. This refractor puts different messaging adapters into its modules for better maintainability and readability.
The test checks for the ordering of the item returned. The view function or the model class doesn’t have any order specified. This cause the tests to fail randomly on different machines. This commit removes that ordering the check and just checks for the availability of the ids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2880
Fixes#2874
Closes#2881
TODOs: