Skip to content

Auction orchestration - #147

Merged
ChristianPavilonis merged 7 commits into
mainfrom
feature/auction-integrations
Jan 28, 2026
Merged

Auction orchestration#147
ChristianPavilonis merged 7 commits into
mainfrom
feature/auction-integrations

Conversation

@ChristianPavilonis

@ChristianPavilonisChristianPavilonis commented Dec 16, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#139

jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md
jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md
jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md
jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md
jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md
jevansnyc
jevansnyc reviewed Dec 17, 2025
View reviewed changes
Comment threadcrates/common/src/auction/README.md Outdated
aram356

This comment was marked as outdated.

Sign in to view

@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/auction-integrations branch from 92c19a7 to 39cb7dcCompareJanuary 9, 2026 00:33
@ChristianPavilonis
ChristianPavilonis marked this pull request as ready for review January 12, 2026 19:24
@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/auction-integrations branch from 39cb7dc to c82ffd3CompareJanuary 13, 2026 16:29
aram356
aram356 requested changes Jan 14, 2026
View reviewed changes

@aram356aram356 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good start

  1. Please address tests and formatting
  2. I would like to re-review

Comment threaddocs/APS_QUICKSTART.md Outdated
Comment threadcrates/common/src/auction/mod.rs
Comment threadcrates/common/src/auction/mod.rs Outdated
Comment threaddocs/guide/aps.md
Comment threadcrates/common/src/integrations/aps.rs Outdated
Comment threadtrusted-server.toml Outdated
Comment threadcrates/common/src/auction/mod.rs Outdated
Comment threadcrates/common/src/auction/orchestrator.rs Outdated
Comment threadcrates/common/src/auction/mod.rs Outdated
Comment threadcrates/common/src/auction/types.rs Outdated
@ChristianPavilonisChristianPavilonis mentioned this pull request Jan 14, 2026
Merged
@aram356aram356 linked an issue Jan 19, 2026 that may be closed by this pull request
As publisher I want to use Amazon APS integration #141
Closed
@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/auction-integrations branch from d694498 to eaee2cfCompareJanuary 20, 2026 20:59
aram356
aram356 requested changes Jan 22, 2026
View reviewed changes
Comment threadcrates/common/src/auction/orchestrator.rs Outdated
Comment threadcrates/common/src/auction/orchestrator.rs
Comment threadcrates/common/src/integrations/aps.rs Outdated
Comment threadcrates/common/src/auction/orchestrator.rs Outdated
Comment threadcrates/common/src/integrations/aps.rs
@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/auction-integrations branch from 8e518c7 to c6dee36CompareJanuary 22, 2026 23:36
aram356
aram356 approved these changes Jan 28, 2026
View reviewed changes

@aram356aram356 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/auction-integrations branch from 0f8cdfd to 040ff1dCompareJanuary 28, 2026 17:31
@ChristianPavilonis
ChristianPavilonis merged commit 488af44 into mainJan 28, 2026
4 checks passed
@aram356
aram356 deleted the feature/auction-integrations branch February 4, 2026 22:12
@prk-Jrprk-Jr mentioned this pull request Mar 26, 2026
Merged
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jevansnycjevansnycjevansnyc left review comments
@aram356aram356aram356 approved these changes

Assignees

@ChristianPavilonisChristianPavilonis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As publisher I want to use Amazon APS integration As developer I want to register header bidding integrations to perform auctions

3 participants

@ChristianPavilonis@aram356@jevansnyc