Skip to content

Add bidder params and debug helpers to openrtb request - #172

Merged
ChristianPavilonis merged 2 commits into
fix/proxy-compression-issuesfrom
feature/kargo-integration
Jan 28, 2026
Merged

Add bidder params and debug helpers to openrtb request#172
ChristianPavilonis merged 2 commits into
fix/proxy-compression-issuesfrom
feature/kargo-integration

Conversation

@ChristianPavilonis

@ChristianPavilonisChristianPavilonis commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

Waiting until #147 is merged.

Comment threadcrates/common/src/integrations/prebid.rs Outdated
@aram356aram356 linked an issue Jan 19, 2026 that may be closed by this pull request
@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/kargo-integration branch 2 times, most recently from fbae661 to 1f11d06CompareJanuary 20, 2026 21:51
@ChristianPavilonis
ChristianPavilonis changed the base branch from main to fix/proxy-compression-issuesJanuary 20, 2026 21:51
@ChristianPavilonis
ChristianPavilonisforce-pushed the feature/kargo-integration branch 2 times, most recently from 1543ff3 to dac30b3CompareJanuary 21, 2026 01:28
@ChristianPavilonis
ChristianPavilonisforce-pushed the fix/proxy-compression-issues branch from 9de521a to d0b99c1CompareJanuary 21, 2026 15:43
@ChristianPavilonis
ChristianPavilonis marked this pull request as ready for review January 21, 2026 15:43

@aram356aram356 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some opportunity to improve it.

Comment threadcrates/common/src/integrations/prebid.rs
Comment threadcrates/common/src/integrations/prebid.rs Outdated
Comment threadcrates/common/src/integrations/prebid.rs Outdated
Comment threadcrates/common/src/integrations/prebid.rs Outdated
Comment threadcrates/common/src/integrations/prebid.rs Outdated
- use concrete types for openrtb
- clean up duplicate code
- removed log statements
- adds fallback for empty bidders

@aram356aram356 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@ChristianPavilonis
ChristianPavilonis merged commit 39b40f9 into fix/proxy-compression-issuesJan 28, 2026
@aram356
aram356 deleted the feature/kargo-integration branch February 4, 2026 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As publisher I want to use Kargo SSP through Prebid server

2 participants

@ChristianPavilonis@aram356