test(ncr): wait for the routing flip instead of a fixed delay — macOS readiness flake - #319
Merged
Merged
Conversation
…S readiness flake Peer_snapshot_refresh_changes_routing_preference_cloud_then_peer writes new mesh peers, sleeps 600 ms for the PeerCapabilitySnapshotPoller (150 ms cadence in the virtual-production host) and asserts the router now prefers a peer. On a slow macOS runner the refresh occasionally lands after the sleep and the leg goes red for nothing (2 of the last 5 readiness runs; Linux and Windows pass the same test). Poll for the routing decision to actually flip, bounded at 10 s; the assertions still produce the real diagnostic on a genuine failure. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last leg of the readiness-gate cleanup. After #317 + #318, the manually dispatched Full Platform Readiness Gate on master
b2613abdwent green on Linux, Windows, Alpine, Debian, Ubuntu-container and the Docker CLI image — Windows included, which is the #318 lock fix proven where it could only be proven. One leg stayed red: macOS, onci verify's ProdStyle sub-step:VirtualProductionNcrRoutingTests.Peer_snapshot_refresh_changes_routing_preference_cloud_then_peer— writes new mesh peers, sleeps a fixed 600 ms for thePeerCapabilitySnapshotPoller(150 ms cadence in the virtual-production host), then asserts the router prefers a peer. On a slow macOS runner the refresh occasionally lands after the sleep. Same test passed on Linux and Windows in the same run; it has shown up in 2 of the last 5 readiness runs — a flake, not a regression.Fix: poll for the routing decision to actually flip (bounded, 10 s) instead of guessing an interval; the assertions still produce the real diagnostic on a genuine failure. Same shape as the sink-test deflake in #317.
Test plan
VirtualProductionNcrRoutingTests3/3 × 3 consecutive runs🤖 Generated with Claude Code