ci(readiness): smoke the API images by starting them and probing /health — old smoke hung 90 min - #320
Merged
Merged
Conversation
…lth — the old smoke hung 90 min With #317-#319 every platform leg of the Full Platform Readiness Gate is green (Linux, Windows, macOS, Alpine, Debian, Ubuntu-container, Docker CLI image) and so is the summary. The run still ended "cancelled": all three production images built in ~1 minute, then their smoke step ran `docker run … "dotnet Nexo.API.dll --help || true"` — an ASP.NET host does not treat --help as a switch, it starts the server and runs forever — and hung until the 90-minute job timeout. It was never noticed because those jobs were cancelled on every earlier run for the same reason. Smoke the thing the images are for instead: run detached with the mock provider, require /health to answer within 120 s (the images' own HEALTHCHECK contract, and the same shape as scripts/ci/distribution-matrix-api-http-smoke.sh), dump container logs on failure, always clean up. Job timeout 90 → 20 minutes; the old budget only ever measured how long a hang could hang. actionlint clean for the new step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
IanFrelinger
commented
Aug 16, 2026
OwnerAuthor
Full gate dispatched on this branch (all legs + Docker smoke): https://github.com/IanFrelinger/Nexo/actions/runs/31956457470 |
Uh oh!
There was an error while loading. Please reload this page.
IanFrelinger pushed a commit
that referenced
this pull request
Aug 17, 2026
…rograms historical; document spikes/ docs/DocsIndex.md: Start Here #1 is the tester quickstart, README #2, GettingStarted #3; IntegratorGuide and consumer-template/CONSUMING.md are listed for the first time; RELEASE.md, the setup-matrix scripts and the bootstrap helpers move out of the numbered list into an "escape hatches" paragraph (RELEASE stays under Operator); a new "Trust loop / certification (experimental, hold-mode)" group makes docs/trust-loop/*, the evidence ledger, governed-pipeline, SELF-EXTEND-AUDIT, the sample objective and spikes/ reachable; "Planning & Roadmap" becomes "Planning history (historical as of 2026-08-16)" because it described a finished program. Stale status docs are date-stamped rather than deleted: - ProtocolIntegration-MCP-A2A.md said the Nexo.API wiring was "planned"; it landed in #269/#270 (Program.cs registers all four adapters and maps /api/mcp and /api/a2a/{agentId}; IngressCatalog rows McpServer/A2AAgents). - ci-pre-existing-failures.md said the Full Platform Readiness Gate was RED as of 06-21; it went green with #317-#320/#335. Kept because docs/planning/* still cite it. - GapAnalysis.md and NorthStarGapAnalysis.md predate the trust loop; both get a historical banner naming their still-open rows and pointing at the ledger, ProjectTiers and CHANGELOG. GettingStarted.md #5 contradicted DocsIndex on "installer" scripts (the scripts/install/* helpers exist but bootstrap the container lane); it now says so and points first-run readers at the quickstart. The pointer to a README section "First Successful Pipeline Run" (which does not exist) now names the sections that do. IntegratorGuide.md recommended `dotnet build Nexo.sln` (the docs guard forbids it in README); it now builds Nexo.Kernel.sln and the CLI project, with hello-brick as the smallest test example, and the compatibility matrix names the solutions that actually apply. spikes/README.md: the 27 tracked files under spikes/ were cited as PASS evidence by the ledger but undocumented. It says what each spike is, every flag of the flight runner, which ledger rows cite each spike, and that none of it is a supported entry point. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last blocker for an all-green Full Platform Readiness Gate — and this one is in the workflow, not the code.
After #317–#319 the dispatched gate on master
e2323ae3was green on every platform leg (Linux, Windows, macOS, Alpine, Debian, Ubuntu-container, Docker CLI image) and the Readiness summary. The run still ended cancelled: all three production images (api, quickstart, agent-server) built in ~1 minute each, then their smoke stephung until the 90-minute job timeout (annotation: "exceeded the maximum execution time of 1h30m0s"). An ASP.NET host doesn't treat
--helpas a switch — it starts Kestrel and runs forever, so|| truenever gets a say. Nobody saw it because those jobs were cancelled on every earlier run for the same reason.Fix: smoke the thing the images are for. Run detached with the mock provider, require
/healthto answer within 120 s — the images' ownHEALTHCHECKcontract, and the same shape as the passingscripts/ci/distribution-matrix-api-http-smoke.sh— dump container logs on failure, always clean up. Job timeout 90 → 20 min (build ~1 min + smoke ≤ 2 min; the old budget only measured how long a hang could hang).actionlintclean for the new step; the matrix's deadsmoke:fields are gone.Test plan
actionlinton the workflow: no findings for the new stepworkflow_dispatch, all legs + Docker smoke) — link in comments🤖 Generated with Claude Code