Uh oh!
There was an error while loading. Please reload this page.
feat(moore): link vLLM silu_and_mul - #874
Merged
voltjia merged 3 commits intoAug 7, 2026
Merged
Conversation
20 tasks
voltjiaforce-pushed
the
feat/linked-moore-silu-and-mul
branch
from
August 5, 2026 11:45
e75f5f7 to
44413c8Comparevoltjiaforce-pushed
the
feat/linked-moore-silu-and-mul
branch
from
August 6, 2026 08:24
44413c8 to
d70f191Comparevoltjia
marked this pull request as ready for review
August 6, 2026 09:07
silu_and_mulZiminli
approved these changes
Aug 6, 2026
whjthu
approved these changes
Aug 7, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
silu_and_mul(at::Tensor&, at::Tensor&)as implementation slot16.vllm.yaml,vllm.h, andvllm.cc, reusing the shared linked Torchsilu_and_multemplate.C10<Device::Type::kMoore>.Motivation
Moore vLLM exposes an optimized
silu_and_mulimplementation through a C++ ABI. InfiniOps links it to the publicsilu_and_mul(input, out)API.C10<Device::Type::kMoore>owns device and stream integration, whileVllmSiluAndMulowns the exact external ABI call.Semantics follow vLLM
SiluAndMul. The pinned Moore image exports:Depends on #873. N/A - no linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_HYGON)WITH_TORCH)Smoke Test Result
Manual runtime evidence at
44413c861c55d825da4b46d3a4d716f8391b96b2:ssh huangjiacheng@172.22.162.98, imagezx_vllm_musa_436:vllm017-cli-ok-mate-disabled(sha256:0431d022137d...), Torch2.7.1, vLLM0.17.1.dev0+gb31e9326a.d20260615.empty.At current head
d70f191b, both Moore main CI and Moore shadow CI pass.Test Results on Supported Platforms
tests/test_silu_and_mul.py:50 passedat44413c86Additional validation
Benchmark / Performance Impact
N/A - this PR changes integration behavior and makes no performance claim.
Notes for Reviewers
vllm.*stem. Platform library YAML contains the Python package and DSO glob.TorchSiluAndMul<Backend>provides tensor conversion, staging, and copy-back.VllmSiluAndMul::Callcontains the exact external ABI call.C10<Device::Type::kMoore>usesc10::musa::getStreamFromExternalandc10::StreamGuard. The guard applies the caller-selected device and stream.<c10/musa/MUSAMacros.h>remains required because that image'sMUSAStream.hdoes not defineC10_MUSA_APIitself.50 passedresult.