Uh oh!
There was an error while loading. Please reload this page.
feat(moore): link vLLM rms_norm - #885
Merged
Merged
Conversation
voltjiaforce-pushed
the
feat/linked-moore-rms-norm
branch
from
August 6, 2026 11:48
71c134c to
8f7646aComparevoltjia
changed the base branch from
feat/linked-moore-silu-and-mul
to
feat/linked-metax-rms-normAugust 6, 2026 11:50
19 tasks
voltjia
marked this pull request as ready for review
August 6, 2026 12:10
Ziminli
approved these changes
Aug 6, 2026
whjthu
approved these changes
Aug 7, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rms_normas linked implementation slot16.TorchRmsNorm<Backend>for tensor conversion, contiguous staging, stream guards, and output copy-back.C10<Device::Type::kMoore>bridge.Motivation
This PR validates that the linked architecture works for a second operator on Moore. InfiniOps keeps
rms_norm(input, weight, eps, out), while the provider ABI is:The exact symbol was verified in the Moore vLLM 0.17.1 development image used by #874. Depends on #884. N/A - no linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Static validation
Benchmark / Performance Impact
N/A - this PR validates linked integration correctness and makes no performance claim.
Notes for Reviewers
C10<Device::Type::kMoore>.TorchRmsNorm<Backend>preserves InfiniOps output-last ordering and stages non-contiguous tensors.rms_norm#884; its diff contains only the Moore provider and MUSA stream coverage.