Skip to content

feat(moore): link vLLM rms_norm - #885

Merged
voltjia merged 1 commit into
feat/linked-metax-rms-normfrom
feat/linked-moore-rms-norm
Aug 7, 2026
Merged

feat(moore): link vLLM rms_norm#885
voltjia merged 1 commit into
feat/linked-metax-rms-normfrom
feat/linked-moore-rms-norm

Conversation

@voltjia

@voltjiavoltjia commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Moore vLLM rms_norm as linked implementation slot 16.
  • Reuse TorchRmsNorm<Backend> for tensor conversion, contiguous staging, stream guards, and output copy-back.
  • Cover CUDA and MUSA non-default streams through the existing C10<Device::Type::kMoore> bridge.

Motivation

This PR validates that the linked architecture works for a second operator on Moore. InfiniOps keeps rms_norm(input, weight, eps, out), while the provider ABI is:

voidrms_norm(at::Tensor& out, at::Tensor& input,
at::Tensor& weight, double epsilon);

The exact symbol was verified in the Moore vLLM 0.17.1 development image used by #874. Depends on #884. N/A - no linked issue.

Type of Change

  • feat - new feature / new operator / new platform
  • fix - bug fix
  • perf - performance improvement (no behavioral change)
  • refactor - code restructuring without behavior change
  • test - adding or fixing tests only
  • docs - documentation only
  • build / ci - build system or CI configuration
  • chore - tooling, formatting, or other non-code changes
  • Breaking change

Platforms Affected

  • CPU (WITH_CPU)
  • NVIDIA (WITH_NVIDIA)
  • Iluvatar (WITH_ILUVATAR)
  • MetaX (WITH_METAX)
  • Cambricon (WITH_CAMBRICON)
  • Moore (WITH_MOORE)
  • Ascend (WITH_ASCEND)
  • PyTorch C++ bindings (WITH_TORCH)
  • Build system / CMake / CI
  • Python bindings / user-facing API

Smoke Test Result

Pending: operator-pruned Moore linked build, tests/test_rms_norm.py, and the existing smoke set.
The source upload to the Moore validation host requires explicit authorization.

Test Results on Supported Platforms

PlatformAffectedBuild / Smoke ResultFull Result / Notes
NVIDIANoN/A - not affectedHost-independent clang-format/Ruff checks only
IluvatarNoN/A - not affectedN/A
MetaXNoN/A - not affectedSeparate draft PR
CambriconNoN/A - not affectedSeparate draft PR
MooreYesPending remote linked buildExact ABI verified in the #874 provider image
AscendNoN/A - not affectedN/A
Static validation
clang-format 21 --dry-run --Werror <changed C++ files>
exit 0
ruff 0.15.22 format --check tests/test_rms_norm.py
1 file already formatted
ruff 0.15.22 check tests/test_rms_norm.py
All checks passed!
git diff --cached --check
exit 0

Benchmark / Performance Impact

N/A - this PR validates linked integration correctness and makes no performance claim.

Notes for Reviewers

  • Provider code contains no CUDA/MUSA preprocessor split; platform behavior remains in C10<Device::Type::kMoore>.
  • TorchRmsNorm<Backend> preserves InfiniOps output-last ordering and stages non-contiguous tensors.
  • This is the sixth PR in the linked-operator stack and depends on feat(metax): link vLLM rms_norm #884; its diff contains only the Moore provider and MUSA stream coverage.

@voltjia
voltjiaforce-pushed the feat/linked-moore-rms-norm branch from 71c134c to 8f7646aCompareAugust 6, 2026 11:48
@voltjia
voltjia changed the base branch from feat/linked-moore-silu-and-mul to feat/linked-metax-rms-normAugust 6, 2026 11:50
@voltjiavoltjia mentioned this pull request Aug 6, 2026
19 tasks
@voltjiavoltjia changed the title feat(moore): link vLLM rms_normfeat(moore): link vLLM rms_normAug 6, 2026
@voltjia
voltjia marked this pull request as ready for review August 6, 2026 12:10
@voltjia
voltjia requested a review from a teamAugust 6, 2026 12:10
@voltjia
voltjia merged commit fff1ff6 into masterAug 7, 2026
10 checks passed
@voltjia
voltjia deleted the feat/linked-moore-rms-norm branch August 7, 2026 11:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@voltjia@whjthu@Ziminli