Skip to content

feat(metax): link vLLM rms_norm - #884

Merged
voltjia merged 1 commit into
feat/linked-cambricon-silu-and-mulfrom
feat/linked-metax-rms-norm
Aug 7, 2026
Merged

feat(metax): link vLLM rms_norm#884
voltjia merged 1 commit into
feat/linked-cambricon-silu-and-mulfrom
feat/linked-metax-rms-norm

Conversation

@voltjia

@voltjiavoltjia commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add MetaX vLLM rms_norm as linked implementation slot 16.
  • Add shared TorchRmsNorm<Backend> handling tensor conversion, contiguous staging, stream guards, and output copy-back.
  • Extend tests/test_rms_norm.py with a non-default stream case.

Motivation

The first linked-operator PR validates one silu_and_mul implementation across providers. This PR checks that the same architecture also supports a structurally different operator with two input tensors, a scalar attribute, and explicit output mapping.

InfiniOps keeps rms_norm(input, weight, eps, out). The installed MetaX vLLM DSO is verified by both nm -D -C and readelf to export:

voidrms_norm(at::Tensor& out, at::Tensor& input,
at::Tensor& weight, double epsilon);

Depends on #876. N/A - no linked issue.

Type of Change

  • feat - new feature / new operator / new platform
  • fix - bug fix
  • perf - performance improvement (no behavioral change)
  • refactor - code restructuring without behavior change
  • test - adding or fixing tests only
  • docs - documentation only
  • build / ci - build system or CI configuration
  • chore - tooling, formatting, or other non-code changes
  • Breaking change

Platforms Affected

  • CPU (WITH_CPU)
  • NVIDIA (WITH_NVIDIA)
  • Iluvatar (WITH_ILUVATAR)
  • MetaX (WITH_METAX)
  • Cambricon (WITH_CAMBRICON)
  • Moore (WITH_MOORE)
  • Ascend (WITH_ASCEND)
  • PyTorch C++ bindings (WITH_TORCH)
  • Build system / CMake / CI
  • Python bindings / user-facing API

Smoke Test Result

Pending: operator-pruned MetaX linked build, tests/test_rms_norm.py, and the existing smoke set.
The source upload to the MetaX validation host requires explicit authorization.

Test Results on Supported Platforms

PlatformAffectedBuild / Smoke ResultFull Result / Notes
NVIDIANoN/A - not affectedHost-independent clang-format/Ruff checks only
IluvatarNoN/A - not affectedN/A
MetaXYesPending remote linked buildExported ABI verified in the pinned vLLM DSO
CambriconNoN/A - not affectedSeparate draft PR
MooreNoN/A - not affectedSeparate draft PR
AscendNoN/A - not affectedN/A
Static validation
clang-format 21 --dry-run --Werror <changed C++ files>
exit 0
ruff 0.15.22 format --check tests/test_rms_norm.py
1 file already formatted
ruff 0.15.22 check tests/test_rms_norm.py
All checks passed!
git diff --cached --check
exit 0

Benchmark / Performance Impact

N/A - this PR validates linked integration correctness and makes no performance claim.

Notes for Reviewers

@voltjia
voltjiaforce-pushed the feat/linked-metax-rms-norm branch from e7a0587 to 69d1af7CompareAugust 6, 2026 11:46
@voltjia
voltjia changed the base branch from feat/linked-metax-silu-and-mul to feat/linked-cambricon-silu-and-mulAugust 6, 2026 11:50
@voltjiavoltjia mentioned this pull request Aug 6, 2026
19 tasks
@voltjiavoltjia changed the title feat(metax): link vLLM rms_normfeat(metax): link vLLM rms_normAug 6, 2026
@voltjia
voltjia marked this pull request as ready for review August 6, 2026 12:09
@voltjia
voltjia requested a review from a teamAugust 6, 2026 12:09
@voltjia
voltjia merged commit 265e181 into masterAug 7, 2026
10 checks passed
@voltjia
voltjia deleted the feat/linked-metax-rms-norm branch August 7, 2026 10:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@voltjia@whjthu@Ziminli