Uh oh!
There was an error while loading. Please reload this page.
fix(ops): copy convolution tensor metadata views - #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TensorViewmetadata-view API.Motivation
InfiniRT now returns
ShapeViewandStridesViewfrom lvalueTensorViewobjects. The direct assignments introduced with the canonical convolution operators in #882 therefore fail to compile against current InfiniRT. ExplicitTensor::Shape{...}andTensor::Strides{...}construction matches the existing bias metadata path and works for both owned containers and metadata views.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
WITH_CPU=ONconv2d: 18 passedBenchmark / Performance Impact
N/A. This only makes existing metadata copies explicit.
Notes for Reviewers
clang-format 21.1.8 --dry-run --Werror src/common/op_utils/conv.hpassed.Conv2d,Copy,Relu, andSiluAndMulcompile successfully against this commit and current InfiniRT.