Uh oh!
There was an error while loading. Please reload this page.
refactor(cuda): adapt ConvInfinilm to Convolution - #898
Merged
Conversation
voltjia
marked this pull request as ready for review
August 7, 2026 07:25
ConvInfinilm to ConvolutionUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvInfinilmprovider as a thin adapter over canonicalConvolution.Motivation
ConvInfinilmrepresents the non-transposed, zero-output-padding subset of the PyTorch-alignedConvolutionoperator added in #882. This PR makes the canonical provider the single implementation while retaining the deprecated InfiniLM compatibility entry point.This is a stacked PR based on #887 because canonical
Convolutionmust copy current InfiniRT metadata views into owning metadata before it can be constructed.No issue is closed by this PR.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
NVIDIA validation used
accelerator-dev/nvidia:lateston an A100 host. The tested stack was #887 followed by this PR:Repository checks:
Test Results on Supported Platforms
opsbuild passedFull focused `pytest` output
Benchmark / Performance Impact
N/A. The adapter calls the same canonical convolution kernel and this PR makes no performance claim.
Notes for Reviewers
Alignment table
ConvInfinilm(input, weight, bias, padding, stride, dilation, groups, out)Convolution(input, weight, bias, stride, padding, dilation, transposed=false, output_padding=zeros, groups, out)convolutionschematransposed=falseand zerooutput_padding.CudaConv<Backend, Convolution>provider before every call.