Uh oh!
There was an error while loading. Please reload this page.
repeat with axis=None repeats flattened array - #1427
Merged
Conversation
Adds tests for new functionality
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_2 ran successfully. |
axis=None repeats flattened arrayaxis=None repeats flattened arrayaxis=None repeats flattened arrayoleksandr-pavlyk
commented
Oct 2, 2023
Contributor
Docstring pertaining to description of |
Docstring has been adjusted to reflect changes to `axis` as well as new `repeats` types Corrected a bug in the behavior of `repeat` for size 1 `repeats` Python sequences
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1427/index.html |
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_3 ran successfully. |
coveralls
commented
Oct 2, 2023
Collaborator
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_4 ran successfully. |
oleksandr-pavlyk
approved these changes
Oct 4, 2023
oleksandr-pavlyk
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
5 tasks
ndgrigorian added a commit
that referenced
this pull request
Oct 9, 2023
6 tasks
ndgrigorian added a commit
that referenced
this pull request
Oct 9, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR permits
axis=Nonefor any input torepeat.To do so, the previously implemented kernels for repeat were tweaked to permit this behavior, and overloads of
py_repeat_by_sequenceandpy_repeat_by_scalarwithoutaxisarguments were implemented. These share an overloaded Python binding, with and without anaxisargument.