Skip to content

Use dpctl cmake config - #1671

Merged
antonwolfy merged 2 commits into
masterfrom
use_dpctl_build_config
Feb 1, 2024
Merged

Use dpctl cmake config#1671
antonwolfy merged 2 commits into
masterfrom
use_dpctl_build_config

Conversation

@antonwolfy

@antonwolfyantonwolfy commented Jan 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

The PR propose to adapt to the dpctl service improvement from dpctl#1508 which making find_package(Dpctl) works out of the box with dpctl installed in the Python environment.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfyantonwolfy self-assigned this Jan 29, 2024
@github-actions

github-actionsBot commented Jan 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@antonwolfy
antonwolfy marked this pull request as ready for review February 1, 2024 10:27
vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 1, 2024
View reviewed changes

@vlad-perevezentsevvlad-perevezentsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy
antonwolfy merged commit 8cde6c4 into masterFeb 1, 2024
@antonwolfy
antonwolfy deleted the use_dpctl_build_config branch February 1, 2024 13:37
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Feb 1, 2024
@github-actions
Use dpctl cmake config (IntelPython#1671)8cde6c4
1dc522a
@vtavanavtavana mentioned this pull request Feb 2, 2024
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsevvlad-perevezentsevvlad-perevezentsev approved these changes
@npolina4npolina4Awaiting requested review from npolina4
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

@antonwolfyantonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy@vlad-perevezentsev