Skip to content

update build_locally.py - #1677

Merged
vtavana merged 5 commits into
masterfrom
update_build_local_files
Feb 3, 2024
Merged

update build_locally.py#1677
vtavana merged 5 commits into
masterfrom
update_build_local_files

Conversation

@vtavana

@vtavanavtavana commented Feb 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Due to the recent changes in #1671 , we also have to modify script/build_locally.py to pass -DDpctl_ROOT=$(python -m dpctl --cmakedir). This parameter is needed when dpctl is also built locally.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Feb 2, 2024
@github-actions

github-actionsBot commented Feb 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

antonwolfy
antonwolfy approved these changes Feb 2, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

Comment threadscripts/build_locally.py
@vtavana
vtavana marked this pull request as ready for review February 2, 2024 14:59
@vtavana
vtavana merged commit 38a7ca8 into masterFeb 3, 2024
@vtavana
vtavana deleted the update_build_local_files branch February 3, 2024 04:35
github-actionsBot added a commit that referenced this pull request Feb 3, 2024
@github-actions
updatebuild_locally.py(#1677)
d4694aa
* update build_locally.py
* fix pre-commit
* add comments
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 38a7ca8
@antonwolfyantonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy