Skip to content

Add dotnet tool ability to XMLtoMD proj - #157

Merged
Keboo merged 10 commits into
mainfrom
xmltomd-DotNetToolnet3.1
Apr 7, 2021
Merged

Add dotnet tool ability to XMLtoMD proj#157
Keboo merged 10 commits into
mainfrom
xmltomd-DotNetToolnet3.1

Conversation

@BenjaminMichaelis

@BenjaminMichaelisBenjaminMichaelis commented Mar 6, 2021

Copy link
Copy Markdown
Member
  • DragonFruit CLI tool added
  • pack and nupkg tool ability added

BenjaminMichaelisand others added 7 commits March 3, 2021 16:41
@BenjaminMichaelis
Modify to run with .net5.0 #WIP
d0890c5
- upgraded from .netcore3.1 to .net5.0
- suppressed warning syslib0012
Will need to address https://docs.microsoft.com/en-us/dotnet/core/compatibility/syslib-warnings/syslib0012
Most likely by using Assembly.Location
@BenjaminMichaelis
Add pack ability
38805ea
- added XML nodes for ability to pack and distribute the application as a nupkg
@BenjaminMichaelis
Add nupkg tool
42cd15f
@twofingerrightclick
add DragonFruit cli tool
3ce0e46
@twofingerrightclick
dotnet 5 and added dragonfruit command line for running locally.
648bfc3
@twofingerrightclick@BenjaminMichaelis
minor format cleaning
cc05711
@BenjaminMichaelis
.netcore3.1
97147f8
.Net 5.0 upgrade will be coming in the future
@BenjaminMichaelisBenjaminMichaelis added the enhancement New feature or request label Mar 6, 2021
@BenjaminMichaelisBenjaminMichaelis mentioned this pull request Mar 6, 2021
Closed
Keboo
Keboo reviewed Mar 10, 2021
View reviewed changes
Comment threadXMLtoMD/GuidelineXmlToMD/GuidelineXmlToMD.csproj Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/MarkdownOut/MdWriter.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/MarkdownOut/MdWriter.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
/// <param name="i">The xml file to process when using the -m option</param>
/// <param name="o">The md file to create when using the -m option </param>
/// <param name="m">Manual Run - Use xmlFilePath and outputMDFilePath</param>
static void Main(string[] args, string xmlFileName, string i = "null", string o = "null", bool m = false)

@KebooKebooMar 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to take in the string args and instead just specify the parameters that you need.

This will likely require changing the invocation on the GitHub Action.
You can use FileInfo as the parameter type and it will properly parse it for you.

Suggested change
staticvoidMain(string[]args,stringxmlFileName,stringi="null",stringo="null",boolm=false)
staticvoidMain(stringxmlFileName,stringi="null",stringo="null",boolm=false)

@twofingerrightclicktwofingerrightclickMar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed default args []

Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
Comment threadXMLtoMD/GuidelineXmlToMD/Program.cs Outdated
twofingerrightclickand others added 2 commits March 10, 2021 15:29
@twofingerrightclick@Keboo
Apply suggestions from code review
1b90a57
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
@twofingerrightclick
revisions based on Kevin's Comments
432058d
Base automatically changed from master to mainMarch 11, 2021 22:46
@BenjaminMichaelis

BenjaminMichaelis commented Mar 30, 2021

Copy link
Copy Markdown
MemberAuthor

What's the status on this? @Keboo

@Keboo

Keboo commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

Fixes #160
Fixes #159

@Keboo
Keboo merged commit 9dd61df into mainApr 7, 2021
@Keboo
Keboo deleted the xmltomd-DotNetToolnet3.1 branch April 7, 2021 21:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@twofingerrightclicktwofingerrightclicktwofingerrightclick left review comments
@KebooKebooKeboo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminMichaelis@Keboo@twofingerrightclick