fix: switch ArenaAllocator to VirtualAlloc/mmap with on-demand page commit - #531
Merged
Merged
Conversation
JeanPhilippeKernel
force-pushed
the
user/kernel/fix-arena-alloc
branch
3 times, most recently
from
June 29, 2026 14:08
96cee0e to
e1c0649
Compare
JeanPhilippeKernel
force-pushed
the
user/kernel/fix-arena-alloc
branch
4 times, most recently
from
June 29, 2026 15:19
08cbb5f to
7b83f75
Compare
JeanPhilippeKernel
marked this pull request as ready for review
June 29, 2026 15:40
JeanPhilippeKernel
force-pushed
the
user/kernel/fix-arena-alloc
branch
from
June 29, 2026 17:20
7b83f75 to
dd64969
Compare
JeanPhilippeKernel
force-pushed
the
user/kernel/fix-arena-alloc
branch
2 times, most recently
from
June 29, 2026 22:16
310363e to
75ef78e
Compare
JeanPhilippeKernel
force-pushed
the
user/kernel/fix-arena-alloc
branch
from
June 29, 2026 23:09
75ef78e to
a2cee43
Compare
jnyfah
approved these changes
Jun 30, 2026
This was referenced Jul 2, 2026
Closed
JeanPhilippeKernel
added a commit
that referenced
this pull request
Sep 3, 2026
…mpleted/ Verified every doc's completion claim against the actual codebase — file existence, key symbols, checklist items — rather than trusting the Status line alone. Two categories of finding: Checklist-hygiene gaps (real implementation, boxes just never ticked): render-resource-manager.md, vfs-ticket2/4/5. Ticked every item after confirming the referenced file/symbol/test exists. render-resource-manager.md also got a naming-divergence note — the doc's proposed GPUResource.h/ GPUBuffer/GPUImage shipped as GpuAllocator.h's BufferView/BufferImage instead; functionally identical, different names. Genuine correctness gap: fly-camera-redesign.md claimed 'Implemented' with every one of its own checklist items unchecked, and describes an entirely different architecture (FlyCameraInput/FlyCameraState/EditorCameraController) than what's actually in FlyCameraController.h (CamState enum, SetViewportRect self-gating). Corrected the status to flag this and pointed at the real design so a future reader isn't misled. memory-allocator-audit.md — added a scope note: its 13 bugs (#497/#531) are genuinely all fixed, but later, unrelated allocator bugs were found and fixed independently this cycle (#680-683, #697, #728, #731) — pointed to the wiki's Memory Management page for the current picture. Moved to ZEngine/docs/completed/ (verified, no open items): asset-manager.md, memory-allocator-audit.md, vfs-design.md, vfs-ticket2/3/4/5/6, gpu-allocator-rearchitecture.md, render-resource-manager.md, system-scheduler.md, ui-system.md. Left in place — genuinely partial: tlsf-allocator-integration.md (Phase 3 blocked), logging-policy.md (real outstanding verification/benchmark tasks), fly-camera-redesign.md (needs a content rewrite, not just a status fix), and everything already marked Design/Planning/In Progress/Partially implemented. Cross-checked every backtick-quoted reference to the 12 moved filenames across the rest of the docs tree — all are informal textual mentions, not markdown hyperlinks, so nothing broke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses reported bugs from memory-allocator-audit