Skip to content

added typemin/max for AbstractGray - #62

Merged
timholy merged 1 commit into
JuliaGraphics:masterfrom
bjarthur:bja/typeminmax
Feb 15, 2017
Merged

added typemin/max for AbstractGray#62
timholy merged 1 commit into
JuliaGraphics:masterfrom
bjarthur:bja/typeminmax

Conversation

@bjarthur

@bjarthur bjarthur commented Nov 13, 2016

Copy link
Copy Markdown
Member

see discussion here

@bjarthur

bjarthur commented Nov 13, 2016

Copy link
Copy Markdown
Member Author

the tests won't pass until JuliaMath/FixedPointNumbers.jl#61 is merged and tagged.

@tlnagy

tlnagy commented Jan 24, 2017

Copy link
Copy Markdown
Member

Can you close/open this to restart the tests? JuliaMath/FixedPointNumbers.jl#61 has merged so they should pass.

@timholy timholy closed this Jan 24, 2017
@timholy timholy reopened this Jan 24, 2017
@bjarthur

bjarthur commented Jan 25, 2017

Copy link
Copy Markdown
Member Author

fixedpointnumbers needs to be tagged as well for this PR to work. given that 61 is the only commit since the last tag, it might not make sense to do so yet.

@tlnagy

tlnagy commented Jan 25, 2017

Copy link
Copy Markdown
Member

Once JuliaMath/FixedPointNumbers.jl#62 is merged, we could probably tag a new release.

@codecov-io

codecov-io commented Jan 31, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #62 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   64.68%   64.81%   +0.13%     
==========================================
  Files           1        1              
  Lines         269      270       +1     
==========================================
+ Hits          174      175       +1     
  Misses         95       95
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 64.81% <100%> (+0.13%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b086d...e2584b5. Read the comment docs.

@bjarthur bjarthur mentioned this pull request Jan 31, 2017
Merged
@bjarthur bjarthur closed this Feb 8, 2017
@bjarthur bjarthur reopened this Feb 8, 2017
@bjarthur

bjarthur commented Feb 8, 2017

Copy link
Copy Markdown
Member Author

running tests since JuliaMath/FixedPointNumbers.jl#61 is tagged

@bjarthur

bjarthur commented Feb 9, 2017

Copy link
Copy Markdown
Member Author

tests are passing. will merge in a couple days unless someone has an objection.

timholy
timholy reviewed Feb 10, 2017
View reviewed changes
Comment thread test/runtests.jl Outdated

@testset "typemin/max" begin
for T in (Normed{UInt8,8}, Normed{UInt8,6}, Normed{UInt16,16}, Normed{UInt16,14}, Float32, Float64)
@test typemin(Gray{T}) == typemin(T)

@timholy timholy Feb 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be best to test with ===, e.g., typemin(Gray{T}) === Gray{T}(typemin(T)) or something. Otherwise I don't think we're testing that typemin(T) returns a value of type T.

@bjarthur

bjarthur commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

changed to ===. tests pass so i'll merge in a couple days unless someone voices further concerns.

@timholy
timholy merged commit 2449575 into JuliaGraphics:master Feb 15, 2017
@timholy

timholy commented Feb 15, 2017

Copy link
Copy Markdown
Member

Thanks!

@bjarthur
bjarthur deleted the bja/typeminmax branch April 23, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timholy timholy timholy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bjarthur @tlnagy @codecov-io @timholy