implement rand() - #61
Merged
Merged
Conversation
Current coverage is 88.62% (diff: 100%)@@ master #61 diff @@
==========================================
Files 3 3
Lines 164 167 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 145 148 +3
Misses 19 19
Partials 0 0
|
Member
|
LGTM, but notice the test failures. |
bjarthur
force-pushed
the
bja/rand
branch
4 times, most recently
from
November 12, 2016 21:14
dd29f88 to
a2647ea
Compare
Collaborator
Author
|
i've simplified the tests in this most recent force push. also, please tell me what you think of the hack around JuliaLang/julia#10140 |
This was referenced Nov 13, 2016
Merged
Collaborator
Author
|
i removed the hack, and benchmarked. much faster than the original PR now. i think it's ready to go. will wait a few days for comments before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should set the stage for a subsequent effort to make
rand(Gray{UFixed{UInt16,14}}, 3)work.