Uh oh!
There was an error while loading. Please reload this page.
Experiment: Run graph details for steps, inputs, and outputs - #1102
Conversation
…ow reference for specific protocol types Use ExperimentRunType to provide query row reference for runs
This reverts commit a5c3fac
labkey-jeckels
left a comment
There was a problem hiding this comment.
A few small suggestions, but overall looks good. Thanks for the JavaDoc!
Uh oh!
There was an error while loading. Please reload this page.
| void registerProtocolImplementation(ProtocolImplementation impl); | ||
| void registerProtocolHandler(ExperimentProtocolHandler handler); |
There was a problem hiding this comment.
Since ProtocolImplementation is an implementation of ExperimentProtocolHandler, what's the expectation for registering one? Register as both? Just as a ProtocolImplementation?
There was a problem hiding this comment.
I would like to combine the ProtocolImplementation and ExperimentProtocolHandler implementations and I started to do this refactor, but it was a larger change than I wanted to make right now. The ProtocolImplementation is geared more toward ExperimentRun protocol and requires setting a property on the protocol (which would have required an upgrade script for SampleManager protocols). ExperimentProtocolHandler can be used for ProtocolApplication protocols (see SamplesWorkflowTaskProtocolHandler.)
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # experiment/package-lock.json # experiment/package.json
Rationale
This PR incorporates changes to the Experiment Run Graph to allow for deeper inspection of the lineage for a particular run. Experiment Runs will display Run Step information, along with Data Inputs & Outputs, and Material Inputs & Outputs.
Related Pull Requests
Changes
@labkey/componentsto incorporate UI updates.expType, via theexperiment-lineage.apiwhich provides a more deterministic experiment type than thetypeproperty. (author: @labkey-kevink).ExperimentRunTypeto provide query row reference for runs (author: @labkey-kevink).