Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 8
Experiment: Run graph details for steps, inputs, and outputs#1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
a5c3fac
Enable lineage graph in "Graph Detail View"
labkey-nicka a183c37
Bump @labkey/components
labkey-nicka b847c82
Add expType property to lineage API response
labkey-kevink ca76a1f
Bump @labkey/components
labkey-nicka 24fb455
Add ExperimentProtocolHandler to allow lineage API to provide query r…
labkey-kevink 976e418
Merge branch 'develop' into fb_rungraph_deets
labkey-nicka e5c0f4b
Bump @labkey/components
labkey-nicka 699afd3
Bump @labkey/components
labkey-nicka d47fc71
Bump @labkey/components
labkey-nicka ab437d6
Bump @labkey/components
labkey-nicka 2bc3ed8
Merge branch 'develop' into fb_rungraph_deets
labkey-nicka 750e480
Revert "Enable lineage graph in "Graph Detail View""
labkey-nicka 75c6c01
code review feedback
labkey-kevink 6e27b4a
Use generic URL for data that have DataType but no detail URL (e.g. A…
labkey-kevink bbcb201
Add "datafile" icon
labkey-nicka d0a212c
Add "file" icon
labkey-nicka 82ff762
LineageFilter on null expType nodes
labkey-nicka c133172
Bump @labkey/components
labkey-nicka c268ce9
Use lineage node provided link
labkey-nicka 5c5cb6d
Merge branch 'develop' into fb_rungraph_deets
labkey-nicka 406fdc8
Bump @labkey/components
labkey-nicka bb3a3c7
Use SchemaKey in ExperimentRunType constructor
labkey-kevink db4916a
include container
labkey-kevink 07805a1
return an empty lineage for unknown materials
labkey-kevink 99d8890
Bump @labkey/components
labkey-nicka bcbb9ba
Set lineage API request options
labkey-nicka 6b1a551
Merge branch 'develop' into fb_rungraph_deets
labkey-nicka 0a5fd56
Bump @labkey/components
labkey-nicka aced0b9
betaGraph URL option
labkey-nicka 1f987da
Bump @labkey/components
labkey-nicka 456c780
Merge branch 'develop' into fb_rungraph_deets
labkey-nicka 220f291
Bump @labkey/components
labkey-nicka 1882579
Bump @labkey/components
labkey-nicka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.labkey.api.exp; | ||
| import org.jetbrains.annotations.Nullable; | ||
| import org.labkey.api.exp.api.ExpProtocol; | ||
| import org.labkey.api.exp.api.ExpProtocolApplication; | ||
| import org.labkey.api.exp.api.ExpRun; | ||
| import org.labkey.api.query.QueryRowReference; | ||
| /** | ||
| * Provides some basic recognition for protocols of a particular type. | ||
| */ | ||
| public interface ExperimentProtocolHandler extends Handler<ExpProtocol> | ||
| { | ||
| /** | ||
| * Get a query reference for the protocol type. | ||
| */ | ||
| public @Nullable QueryRowReference getQueryRowReference(ExpProtocol protocol); | ||
| /** | ||
| * Get a query reference for the run of the protocol type. | ||
| */ | ||
| public @Nullable QueryRowReference getQueryRowReference(ExpProtocol protocol, ExpRun run); | ||
| /** | ||
| * Get a query reference for the protocol application of the protocol type. | ||
| */ | ||
| public @Nullable QueryRowReference getQueryRowReference(ExpProtocol protocol, ExpProtocolApplication app); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19 api/src/org/labkey/api/exp/api/ExperimentJSONConverter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 7 additions & 1 deletion
8 api/src/org/labkey/api/exp/query/ExpProtocolApplicationTable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ProtocolImplementation is an implementation of ExperimentProtocolHandler, what's the expectation for registering one? Register as both? Just as a ProtocolImplementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to combine the ProtocolImplementation and ExperimentProtocolHandler implementations and I started to do this refactor, but it was a larger change than I wanted to make right now. The ProtocolImplementation is geared more toward ExperimentRun protocol and requires setting a property on the protocol (which would have required an upgrade script for SampleManager protocols). ExperimentProtocolHandler can be used for ProtocolApplication protocols (see SamplesWorkflowTaskProtocolHandler.)