Uh oh!
There was an error while loading. Please reload this page.
Update redirect() and eliminate HttpRedirectView - #6862
Merged
Conversation
labkey-jeckels
approved these changes
Jul 21, 2025
labkey-jeckels
left a comment
Contributor
There was a problem hiding this comment.
I didn't manually test this. I haven't looked at the callers to inform if/how to test. Any recommendations?
| } | ||
| if (!isPrint() && !(reportView instanceof HttpRedirectView) && DiscussionService.get() != null) | ||
| if (!isPrint() && DiscussionService.get() != null) |
Contributor
There was a problem hiding this comment.
This makes me even happier to eliminate HttpRedirectView.
labkey-adam
commented
Jul 22, 2025
ContributorAuthor
No recommendations... I'm hoping automated tests would have shown issues. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Eliminate
HttpView.redirect(URLHelper)method in favor of other variants that take anActionURLor aURLHelperplus a boolean indicating whether redirecting to an external URL is allowed. This tightens up security and reduces surprises.Also eliminate
HttpRedirectViewin favor of throwingRedirectException.Tasks 📍