Skip to content

Fix link reports - #6876

Merged
labkey-adam merged 3 commits into
developfrom
fb_link_reports
Jul 25, 2025
Merged

Fix link reports#6876
labkey-adam merged 3 commits into
developfrom
fb_link_reports

Conversation

@labkey-adam

@labkey-adamlabkey-adam commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Rationale

Related PR changed redirect() to throw RedirectException instead of returning an HttpRedirectView. ReportsController.getRunReportView() was catching all exceptions and rendering them as errors. Just need to change that action to pass RedirectException on.

Related Pull Requests

Tasks 📍

  • Needs Automation - No: plenty of existing automated tests caught

@labkey-adam
labkey-adam requested a review from a teamJuly 24, 2025 17:42
@labkey-adamlabkey-adam self-assigned this Jul 24, 2025
Comment threadquery/src/org/labkey/query/reports/ReportsController.java Outdated
@labkey-adam

Copy link
Copy Markdown
ContributorAuthor

@labkey-adam
labkey-adam merged commit e29f0cc into developJul 25, 2025
10 checks passed
@labkey-adam
labkey-adam deleted the fb_link_reports branch July 25, 2025 17:31
labkey-jeckels pushed a commit that referenced this pull request Sep 2, 2025
labkey-jeckels pushed a commit that referenced this pull request Sep 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-adam@labkey-klum