Delivery dagid-schema-pattern - #413
Merged
Merged
Conversation
Release train: headless /init stamp fix + v1.0.30 series notes
llama.cpp's OpenAI-compatible server rejects tool schemas whose pattern
lacks ^...$ anchoring. isStartsWith("dag") serialized to ^dag and broke
every request carrying the workflow tool. isPattern(/^dag.*$/) keeps
identical starts-with semantics with a fully anchored pattern.LeXwDeX
marked this pull request as ready for review
August 21, 2026 02:29
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#412
Why
llama.cpp's OpenAI-compatible server rejects tool JSON Schemas whose
patternis not anchored at both ends.DagID'sSchema.isStartsWith("dag")serialized topattern: "^dag"(start-anchored only), so every request carrying the workflow tool (5 parameters referenceDag.ID) failed withJSON schema conversion failed: Pattern must start with '^' and end with '$'.What changed
packages/schema/src/dag-event.ts:DagIDfilter switched fromisStartsWith("dag")toisPattern(/^dag.*$/)— fully anchored pattern, identical starts-with validation semantics.packages/schema/test/dag-id-pattern.test.ts: regression test asserting every serialized pattern is^...$-anchored and validation semantics are unchanged.Evidence
^dagfailed both-anchors assertion), green after.bun testin packages/schema: 19 pass.bun test test/dagin packages/opencode: 615 pass;bun run test:dag-core: gate passed.bun typecheckin packages/schema and packages/opencode: clean.^dag.*$tool pattern is accepted (previously 400).Checklist
^dagpatterns)