Skip to content

Comments and refactoring - #3

Merged
loudnate merged 3 commits into
devfrom
refactor
May 27, 2016
Merged

Comments and refactoring#3
loudnate merged 3 commits into
devfrom
refactor

Conversation

@loudnate

Copy link
Copy Markdown
Collaborator

Preparing for #1

@loudnateloudnate added this to the 0.2.0 milestone May 27, 2016
@loudnate
loudnate merged commit 3c4d2b1 into devMay 27, 2016
@loudnate
loudnate deleted the refactor branch May 27, 2016 04:30
awaxa pushed a commit to awaxa/Loop that referenced this pull request Jul 26, 2017
Moving MinimedKit framework over to RileyLink_ios
channemann added a commit that referenced this pull request Sep 11, 2017
ps2 pushed a commit that referenced this pull request Dec 19, 2017
kenstack referenced this pull request in kenstack/Loop Feb 17, 2018
erikdi pushed a commit to erikdi/Loop that referenced this pull request Feb 10, 2019
ps2 added a commit that referenced this pull request Mar 5, 2019
dthornley pushed a commit to dthornley/Loop that referenced this pull request Oct 9, 2019
…5f4d96a2bbeef7
parent a4568c4
author Cal Young <cyoung1024@gmail.com> 1565904731 +0200
committer David Thornley <david.thornley@darnt.com> 1570653504 +0200
# This is a combination of 6 commits.
# This is the 1st commit message:
Add Spike Client and change version
# This is the commit message LoopKit#2:
Add Spike as CGM source
# This is the commit message LoopKit#3:
Add Spike frameworks
# This is the commit message LoopKit#4:
Add Spike to LSApplicationQueriesSchemes
# This is the commit message LoopKit#5:
Update Cartfile.resolved
# This is the commit message LoopKit#6:
Add Spike Calibration guide
# This is the commit message LoopKit#11:
Fixed delay between Spike update and Loop update
dthornley pushed a commit to dthornley/Loop that referenced this pull request Nov 5, 2019
* draft UI
* New Microboluses Screen
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 5, 2019
* dev-ivan: (27 commits)
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
rewrite loop()
Max Microbolus Size title
Microbolus refactoring
do not show bolus screen if microboluses is enabled
Fix explanation of MB
Microboluses in settings
Micro Boluses!
NSAllowsArbitraryLoads
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 7, 2019
* dev-minimumBolusLimit: (34 commits)
Fix setting not being saved.
Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
Fix typos
Log what is being recommended.
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
rewrite loop()
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 7, 2019
* dev-minimumBolusLimit: (35 commits)
Fix setting not being saved.
Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
Fix typos
Log what is being recommended.
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 7, 2019
* dev-minimumBolusLimit: (34 commits)
Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
Fix typos
Log what is being recommended.
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
rewrite loop()
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 7, 2019
* dev-minimumBolusLimit: (34 commits)
Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
Fix typos
Log what is being recommended.
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
rewrite loop()
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 10, 2019
* dev-minimumBolusLimit: (36 commits)
Update message and the display format of the values for minimum units to deliver
Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
Fix typos
Log what is being recommended.
Fix texts
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 11, 2019
…olus-dt
* ivalkou/dev-ivan: (33 commits)
Add ability to define a lower limit before performing the bolus (LoopKit#4)
Fix texts
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
spikeapp scheme supported
Fix version & skip bolus screen on Watch
rewrite loop()
Max Microbolus Size title
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Nov 14, 2019
…olus-dt
* ivalkou/dev-ivan: (37 commits)
MB with COB and without COB work independently
revert notification names
Cartfile.resolved
Notification names changed in LoopKit (LoopKit#1165)
Add ability to define a lower limit before performing the bolus (LoopKit#4)
Fix texts
Safe Mode refactored
nonlinear-carb-model
Revert "Carb Absorption Model UI"
Carb Absorption Model UI
Microboluses Safe Mode
Add 15 min control clucose chek
Fix MB without COM
Bump version
Microbolus screen (LoopKit#3)
build version changed
disable Microboluses if closed loop disabled
misprint fixed
little refactor
fix 0 bolus bug
...
# Conflicts:
#	Cartfile
#	Loop.xcodeproj/project.pbxproj
#	Loop/Managers/CGMManager.swift
dthornley added a commit to dthornley/Loop that referenced this pull request Dec 29, 2019
commit a11b593
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Dec 26 15:49:31 2019 +0300
Show last MB event in settings
commit 8773d77
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 25 17:34:33 2019 +0300
Microbolus.Event
commit 519609c
Merge: 626630e62952ae
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:30:11 2019 +0300
Merge branch 'dev-ivan' into microboluses
# Conflicts:
#	Loop.xcconfig
#	Loop/Views/MicrobolusView.swift
#	LoopCore/Microbolus.swift
commit 62952ae
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:28:15 2019 +0300
Set default partial application rate to 0.3
commit 310ffac
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:13:17 2019 +0300
add 'Not Limited' option to max sizes of MB
commit 626630e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:53:43 2019 +0300
The view is divided into small parts.
commit 1ff5463
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:53:43 2019 +0300
The view is divided into small parts.
commit 3f688b1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:23:53 2019 +0300
MicrobolusView refactored
commit 1a991ec
Merge: 74ef344a098d6a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:26:18 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into dev-ivan
commit db44386
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:23:53 2019 +0300
MicrobolusView refactored
commit 491458d
Merge: 2abf5dba098d6a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 12:55:02 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into microboluses
commit 2abf5db
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Dec 22 12:41:30 2019 +0300
Clear marketing version
commit b7d2c43
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Dec 22 12:35:13 2019 +0300
Clear signing
commit 74ef344
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 17:02:26 2019 +0300
bump version
commit 56bcbb5
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 16:59:50 2019 +0300
Partial bolus application UI setting
commit 641f83f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:55:03 2019 +0300
partialApplication parameter (default 0.5)
commit a40bfa6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 16:59:50 2019 +0300
Partial bolus application UI setting
commit e79049b
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:55:03 2019 +0300
partialApplication parameter (default 0.5)
commit f238db4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:29:47 2019 +0300
Override `hasFinished` check
commit 7a24458
Merge: 09a082d650ffd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:42:12 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into dev-ivan
# Conflicts:
#	Loop.xcconfig
commit f13327a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:39:39 2019 +0300
Revert CURRENT_PROJECT_VERSION
commit 275923f
Merge: 07d63e1650ffd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:38:15 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into microboluses
commit 07d63e1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:29:47 2019 +0300
Override `hasFinished` check
commit c9b97dd
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 13:07:03 2019 +0300
Cleenup unused code
commit 9888b57
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:59:18 2019 +0300
Remove Settings.bundle
commit 03a7f86
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:57:49 2019 +0300
Remove NightscoutAPIClient
commit 86bff4e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:50:15 2019 +0300
Revert "Current time line on charts (LoopKit#6)"
This reverts commit 10f581e.
commit 09a082d
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 20:32:51 2019 +0300
Disabled pickers fixed
commit d4841ed
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 18:39:49 2019 +0300
bump version
commit 8498438
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 18:31:33 2019 +0300
adaptiveRateNonlinear switch in settings
commit d36f713
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 17:51:17 2019 +0300
Fix binding and update UI
commit bbb0538
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Dec 17 16:25:40 2019 +0300
busines logic and UI
commit 31974cb
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 14 18:33:32 2019 +0300
model and view
commit 0d28665
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 15:04:51 2019 +0300
bump version
commit 61308c8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 14:00:55 2019 +0300
Remove UIApplication.protectedDataDidBecomeAvailableNotification
commit 82243de
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 13:55:49 2019 +0300
Cancel MB if already bolusing
commit 7fa7357
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 17:16:50 2019 +0300
Microbolus refactoring
commit f464c52
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 16:20:53 2019 +0300
NS Client updated
commit c2e028f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:54:02 2019 +0300
Do not open bolus screen after carbs changed
commit 381d957
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:45:50 2019 +0300
Limit MB if current glucose below target
commit dc8b19e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:30:06 2019 +0300
update version
commit 8d42217
Merge: 16edb41d2d9487
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:18:07 2019 +0300
Merge branch 'LoopKit-dev' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit d2d9487
Merge: a24eeb5ac31e0b
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:16:26 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
commit 16edb41
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 17:10:31 2019 +0300
Bolus recommendation notice cancels a microbolus
commit bc10d13
Merge: 8cddb0022543b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 16:01:04 2019 +0300
Merge branch 'empty-settings-fix' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit 22543b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 16:00:02 2019 +0300
Fixed loss of settings after reboot.
commit 8cddb00
Merge: 10f581ee1bcfd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:36:48 2019 +0300
Merge branch 'current-time-lines' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit e1bcfd4
Author: Ivan <zloyfey@gmail.com>
Date: Sat Nov 23 14:57:05 2019 +0300
Current time line on charts (LoopKit#6)
commit a24eeb5
Merge: 430d9ab49412b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:29:38 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit b0869d0
Merge: 430d9ab49412b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:28:48 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit 10f581e
Author: Ivan <zloyfey@gmail.com>
Date: Sat Nov 23 14:57:05 2019 +0300
Current time line on charts (LoopKit#6)
commit 0c25618
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 15 14:37:22 2019 +0300
Revert "revert notification names"
This reverts commit ad62a80.
commit f4b6aaa
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 15 14:16:25 2019 +0300
update cartfile
commit 959fe30
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Nov 13 17:26:27 2019 +0300
MB with COB and without COB work independently
commit ad62a80
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:31:21 2019 +0300
revert notification names
commit c9ee230
Merge: 0194ea2430d9ab
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:23:57 2019 +0300
Merge branch 'dev' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit 0194ea2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:22:48 2019 +0300
Cartfile.resolved
commit 430d9ab
Author: Pete Schwamb <pete@schwamb.net>
Date: Thu Nov 7 00:26:24 2019 -0600
Notification names changed in LoopKit (LoopKit#1165)
* Notification names changed in LoopKit
* Bump carthage revs
commit abed78f
Author: David Thornley <david.thornley@darnt.com>
Date: Mon Nov 11 11:26:27 2019 +0100
Add ability to define a lower limit before performing the bolus (LoopKit#4)
* Log what is being recommended.
* Fix typos
* Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
* Update message and the display format of the values for minimum units to deliver
commit 2a2b02e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 9 15:01:21 2019 +0300
Fix texts
commit 1fb94ef
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Nov 7 19:50:39 2019 +0300
Safe Mode refactored
commit 06021b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Nov 7 16:16:32 2019 +0300
nonlinear-carb-model
commit e755e1c
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Wed Nov 6 22:47:13 2019 +0300
Revert "Carb Absorption Model UI"
This reverts commit 1a94f7f.
commit 1a94f7f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Nov 6 20:56:34 2019 +0300
Carb Absorption Model UI
commit ca202c8
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sun Nov 3 01:31:10 2019 +0300
Microboluses Safe Mode
commit f646063
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sat Nov 2 13:20:46 2019 +0300
Add 15 min control clucose chek
commit 785a909
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sat Nov 2 11:05:20 2019 +0300
Fix MB without COM
commit 7ee1917
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 1 21:41:17 2019 +0300
Bump version
commit a4ebeb1
Author: Ivan <zloyfey@gmail.com>
Date: Fri Nov 1 21:37:48 2019 +0300
Microbolus screen (LoopKit#3)
* draft UI
* New Microboluses Screen
commit 9fdd8c2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 31 11:56:03 2019 +0300
build version changed
commit 5e158aa
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 30 17:59:49 2019 +0300
disable Microboluses if closed loop disabled
commit 13db3d2
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Tue Oct 29 21:18:09 2019 +0300
misprint fixed
commit 2d843b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 18:07:45 2019 +0300
little refactor
commit f7047f3
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 16:51:35 2019 +0300
fix 0 bolus bug
commit 3d17aa2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 12:11:35 2019 +0300
spikeapp scheme supported
commit c621ec1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 16:47:27 2019 +0300
Fix version & skip bolus screen on Watch
commit b7b1374
Merge: 5f9df7891a834f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:10:18 2019 +0300
Merge branch 'dev' into dev-ivan
commit 91a834f
Merge: fa494fe3aa8e6e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:09:21 2019 +0300
Merge branch 'LoopKit-dev' into dev
commit 3aa8e6e
Merge: fa494fe9407f8c
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:08:56 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit 5f9df78
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Oct 25 16:40:06 2019 +0300
rewrite loop()
commit 82fc9b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Oct 25 11:47:19 2019 +0300
Max Microbolus Size title
commit 2deafd3
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Thu Oct 24 22:14:06 2019 +0300
Microbolus refactoring
commit 4205e97
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 19:48:19 2019 +0300
do not show bolus screen if microboluses is enabled
commit e40731e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 18:58:03 2019 +0300
Fix explanation of MB
commit c3f0cb8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 18:51:38 2019 +0300
Microboluses in settings
commit 56f151f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 13:37:58 2019 +0300
Micro Boluses!
commit 6190e2d
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 20:07:12 2019 +0300
NSAllowsArbitraryLoads
commit d349c8f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 16:38:16 2019 +0300
Cartfile update
commit 43e4d8c
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 16:36:03 2019 +0300
NightscoutAPIClient added
commit fa494fe
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 11:00:22 2019 -0500
Remote overrides (LoopKit#1131)
* Allow overrides to be enabled via APNs
* Update to NS sent notifications
* Cleanup prints
* Query override history for NS upload
* Bump submodule revs
* Handle indefinite duration override treatment uploads
* Use separate representation for indefinite duration treatments
* Bump cartfile rev
* Send any override changes when uploading loop status
* Bump carthage revisions
* Bump carthage revision
* Fix typo, and log device token
* Carthage dependency revisions
commit d653500
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 09:28:16 2019 -0500
New strategy for asset overrides. Fixes popup warnings (LoopKit#1145)
* New strategy for asset overrides. Fixes popup warnings
* Add DefaultAssets.xcassets back to WatchApp target
commit af99248
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 08:58:10 2019 -0500
Fix issue with PumpManager ble update coming in right after cgm update arrives (LoopKit#1096)
commit 255a7de
Author: katie disimone <kdisimone@mac.com>
Date: Sun Oct 13 06:53:42 2019 -0700
display - for HUD CGM when value is >15 min old (LoopKit#1140)
commit 2c948ec
Author: katie disimone <kdisimone@mac.com>
Date: Sun Oct 13 06:42:28 2019 -0700
hide the saved API secret by default in NS services display (LoopKit#1142)
dthornley added a commit to dthornley/Loop that referenced this pull request Jan 2, 2020
commit a11b593
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Dec 26 15:49:31 2019 +0300
Show last MB event in settings
commit 8773d77
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 25 17:34:33 2019 +0300
Microbolus.Event
commit 519609c
Merge: 626630e62952ae
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:30:11 2019 +0300
Merge branch 'dev-ivan' into microboluses
# Conflicts:
#	Loop.xcconfig
#	Loop/Views/MicrobolusView.swift
#	LoopCore/Microbolus.swift
commit 62952ae
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:28:15 2019 +0300
Set default partial application rate to 0.3
commit 310ffac
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 19:13:17 2019 +0300
add 'Not Limited' option to max sizes of MB
commit 626630e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:53:43 2019 +0300
The view is divided into small parts.
commit 1ff5463
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:53:43 2019 +0300
The view is divided into small parts.
commit 3f688b1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:23:53 2019 +0300
MicrobolusView refactored
commit 1a991ec
Merge: 74ef344a098d6a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:26:18 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into dev-ivan
commit db44386
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 13:23:53 2019 +0300
MicrobolusView refactored
commit 491458d
Merge: 2abf5dba098d6a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Dec 23 12:55:02 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into microboluses
commit 2abf5db
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Dec 22 12:41:30 2019 +0300
Clear marketing version
commit b7d2c43
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Dec 22 12:35:13 2019 +0300
Clear signing
commit 74ef344
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 17:02:26 2019 +0300
bump version
commit 56bcbb5
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 16:59:50 2019 +0300
Partial bolus application UI setting
commit 641f83f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:55:03 2019 +0300
partialApplication parameter (default 0.5)
commit a40bfa6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 16:59:50 2019 +0300
Partial bolus application UI setting
commit e79049b
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:55:03 2019 +0300
partialApplication parameter (default 0.5)
commit f238db4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:29:47 2019 +0300
Override `hasFinished` check
commit 7a24458
Merge: 09a082d650ffd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:42:12 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into dev-ivan
# Conflicts:
#	Loop.xcconfig
commit f13327a
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:39:39 2019 +0300
Revert CURRENT_PROJECT_VERSION
commit 275923f
Merge: 07d63e1650ffd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:38:15 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into microboluses
commit 07d63e1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 21 15:29:47 2019 +0300
Override `hasFinished` check
commit c9b97dd
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 13:07:03 2019 +0300
Cleenup unused code
commit 9888b57
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:59:18 2019 +0300
Remove Settings.bundle
commit 03a7f86
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:57:49 2019 +0300
Remove NightscoutAPIClient
commit 86bff4e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Dec 20 12:50:15 2019 +0300
Revert "Current time line on charts (LoopKit#6)"
This reverts commit 10f581e.
commit 09a082d
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 20:32:51 2019 +0300
Disabled pickers fixed
commit d4841ed
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 18:39:49 2019 +0300
bump version
commit 8498438
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 18:31:33 2019 +0300
adaptiveRateNonlinear switch in settings
commit d36f713
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Dec 18 17:51:17 2019 +0300
Fix binding and update UI
commit bbb0538
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Dec 17 16:25:40 2019 +0300
busines logic and UI
commit 31974cb
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 14 18:33:32 2019 +0300
model and view
commit 0d28665
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 15:04:51 2019 +0300
bump version
commit 61308c8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 14:00:55 2019 +0300
Remove UIApplication.protectedDataDidBecomeAvailableNotification
commit 82243de
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Dec 7 13:55:49 2019 +0300
Cancel MB if already bolusing
commit 7fa7357
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 17:16:50 2019 +0300
Microbolus refactoring
commit f464c52
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 16:20:53 2019 +0300
NS Client updated
commit c2e028f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:54:02 2019 +0300
Do not open bolus screen after carbs changed
commit 381d957
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:45:50 2019 +0300
Limit MB if current glucose below target
commit dc8b19e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:30:06 2019 +0300
update version
commit 8d42217
Merge: 16edb41d2d9487
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:18:07 2019 +0300
Merge branch 'LoopKit-dev' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit d2d9487
Merge: a24eeb5ac31e0b
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 30 15:16:26 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
commit 16edb41
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 17:10:31 2019 +0300
Bolus recommendation notice cancels a microbolus
commit bc10d13
Merge: 8cddb0022543b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 16:01:04 2019 +0300
Merge branch 'empty-settings-fix' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit 22543b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 16:00:02 2019 +0300
Fixed loss of settings after reboot.
commit 8cddb00
Merge: 10f581ee1bcfd4
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:36:48 2019 +0300
Merge branch 'current-time-lines' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit e1bcfd4
Author: Ivan <zloyfey@gmail.com>
Date: Sat Nov 23 14:57:05 2019 +0300
Current time line on charts (LoopKit#6)
commit a24eeb5
Merge: 430d9ab49412b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:29:38 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit b0869d0
Merge: 430d9ab49412b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 23 15:28:48 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit 10f581e
Author: Ivan <zloyfey@gmail.com>
Date: Sat Nov 23 14:57:05 2019 +0300
Current time line on charts (LoopKit#6)
commit 0c25618
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 15 14:37:22 2019 +0300
Revert "revert notification names"
This reverts commit ad62a80.
commit f4b6aaa
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 15 14:16:25 2019 +0300
update cartfile
commit 959fe30
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Nov 13 17:26:27 2019 +0300
MB with COB and without COB work independently
commit ad62a80
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:31:21 2019 +0300
revert notification names
commit c9ee230
Merge: 0194ea2430d9ab
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:23:57 2019 +0300
Merge branch 'dev' into dev-ivan
# Conflicts:
#	Cartfile.resolved
commit 0194ea2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Tue Nov 12 11:22:48 2019 +0300
Cartfile.resolved
commit 430d9ab
Author: Pete Schwamb <pete@schwamb.net>
Date: Thu Nov 7 00:26:24 2019 -0600
Notification names changed in LoopKit (LoopKit#1165)
* Notification names changed in LoopKit
* Bump carthage revs
commit abed78f
Author: David Thornley <david.thornley@darnt.com>
Date: Mon Nov 11 11:26:27 2019 +0100
Add ability to define a lower limit before performing the bolus (LoopKit#4)
* Log what is being recommended.
* Fix typos
* Add a user configurable minimum bolus limit to allow the user to prevent the delivering of very small 0.05 unit boluses
* Update message and the display format of the values for minimum units to deliver
commit 2a2b02e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sat Nov 9 15:01:21 2019 +0300
Fix texts
commit 1fb94ef
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Nov 7 19:50:39 2019 +0300
Safe Mode refactored
commit 06021b8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Nov 7 16:16:32 2019 +0300
nonlinear-carb-model
commit e755e1c
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Wed Nov 6 22:47:13 2019 +0300
Revert "Carb Absorption Model UI"
This reverts commit 1a94f7f.
commit 1a94f7f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Nov 6 20:56:34 2019 +0300
Carb Absorption Model UI
commit ca202c8
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sun Nov 3 01:31:10 2019 +0300
Microboluses Safe Mode
commit f646063
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sat Nov 2 13:20:46 2019 +0300
Add 15 min control clucose chek
commit 785a909
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Sat Nov 2 11:05:20 2019 +0300
Fix MB without COM
commit 7ee1917
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Nov 1 21:41:17 2019 +0300
Bump version
commit a4ebeb1
Author: Ivan <zloyfey@gmail.com>
Date: Fri Nov 1 21:37:48 2019 +0300
Microbolus screen (LoopKit#3)
* draft UI
* New Microboluses Screen
commit 9fdd8c2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 31 11:56:03 2019 +0300
build version changed
commit 5e158aa
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 30 17:59:49 2019 +0300
disable Microboluses if closed loop disabled
commit 13db3d2
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Tue Oct 29 21:18:09 2019 +0300
misprint fixed
commit 2d843b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 18:07:45 2019 +0300
little refactor
commit f7047f3
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 16:51:35 2019 +0300
fix 0 bolus bug
commit 3d17aa2
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Mon Oct 28 12:11:35 2019 +0300
spikeapp scheme supported
commit c621ec1
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 16:47:27 2019 +0300
Fix version & skip bolus screen on Watch
commit b7b1374
Merge: 5f9df7891a834f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:10:18 2019 +0300
Merge branch 'dev' into dev-ivan
commit 91a834f
Merge: fa494fe3aa8e6e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:09:21 2019 +0300
Merge branch 'LoopKit-dev' into dev
commit 3aa8e6e
Merge: fa494fe9407f8c
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Sun Oct 27 15:08:56 2019 +0300
Merge branch 'dev' of https://github.com/LoopKit/Loop into LoopKit-dev
# Conflicts:
#	Cartfile.resolved
commit 5f9df78
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Oct 25 16:40:06 2019 +0300
rewrite loop()
commit 82fc9b6
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Fri Oct 25 11:47:19 2019 +0300
Max Microbolus Size title
commit 2deafd3
Author: Ivan Valkou <ivalkou@gmail.com>
Date: Thu Oct 24 22:14:06 2019 +0300
Microbolus refactoring
commit 4205e97
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 19:48:19 2019 +0300
do not show bolus screen if microboluses is enabled
commit e40731e
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 18:58:03 2019 +0300
Fix explanation of MB
commit c3f0cb8
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 18:51:38 2019 +0300
Microboluses in settings
commit 56f151f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Thu Oct 24 13:37:58 2019 +0300
Micro Boluses!
commit 6190e2d
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 20:07:12 2019 +0300
NSAllowsArbitraryLoads
commit d349c8f
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 16:38:16 2019 +0300
Cartfile update
commit 43e4d8c
Author: Ivan Valkou <zloyfey@gmail.com>
Date: Wed Oct 23 16:36:03 2019 +0300
NightscoutAPIClient added
commit fa494fe
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 11:00:22 2019 -0500
Remote overrides (LoopKit#1131)
* Allow overrides to be enabled via APNs
* Update to NS sent notifications
* Cleanup prints
* Query override history for NS upload
* Bump submodule revs
* Handle indefinite duration override treatment uploads
* Use separate representation for indefinite duration treatments
* Bump cartfile rev
* Send any override changes when uploading loop status
* Bump carthage revisions
* Bump carthage revision
* Fix typo, and log device token
* Carthage dependency revisions
commit d653500
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 09:28:16 2019 -0500
New strategy for asset overrides. Fixes popup warnings (LoopKit#1145)
* New strategy for asset overrides. Fixes popup warnings
* Add DefaultAssets.xcassets back to WatchApp target
commit af99248
Author: Pete Schwamb <pete@schwamb.net>
Date: Sun Oct 13 08:58:10 2019 -0500
Fix issue with PumpManager ble update coming in right after cgm update arrives (LoopKit#1096)
commit 255a7de
Author: katie disimone <kdisimone@mac.com>
Date: Sun Oct 13 06:53:42 2019 -0700
display - for HUD CGM when value is >15 min old (LoopKit#1140)
commit 2c948ec
Author: katie disimone <kdisimone@mac.com>
Date: Sun Oct 13 06:42:28 2019 -0700
hide the saved API secret by default in NS services display (LoopKit#1142)
jeremybarnum pushed a commit to jeremybarnum/Loop that referenced this pull request May 12, 2022
…l_defaultOFF
Adaptive rate nonlinear model default off
ps2 pushed a commit that referenced this pull request Feb 20, 2023
* Add unannounced meal func to CarbStoreProtocol
* V1 of UAM algo
* Add debug logs
* Handle unannounced meal notification & open up controller
* Add mealstart to notification userinfo
* Improve notification description
* Add direct entry to carb flow from notification on watch
* Add auto-setting of carb entry on watch
* carbThreshold -> mealCarbThreshold
* Retract UAM notifications after the carbs have expired
* Improve function naming
* Move notification logic from LoopKit to Loop
* Make current date configurable
* Make current date configurable during unit testing
* Update status enum naming for point-of-use clarity
* Make 'now' time configurable
* Extract loop data manager testing logic into base class
* Extract loop data manager dosing tests into their own file
* Add unannounced meal tests
* Fix concurrency issue
* Pull UAM constants into separate struct
* Fix notifications not being retracted after their expiration date
* Expire using start of meal instead of current time
* Add unannounced meal notifications permission
* Add AlertPermissionsViewModel
* Remove unneeded `AnyView`s
* Removed unused completion block
* Use the counteraction effects passed into the function
* Schedule missed meal notifications to avoid notification during an microbolus (#3)
* Delay missed meal notification if possible to avoid delivering it during an autobolus
* Add tests for notification delay
* Update `estimatedDuration` function headers in response to PR feedback
* Add UAM banner to carb entry screen (#5)
* Add warning banner to remind the user to edit the meal estimate
* Update warning text
* UAM algo updates: only use directly observed carb absorption (#6)
* Add ability to calculate the number of carbs in a missed meal (#4)
* Plumb a customizable carb amount through UAM notification architecture
* Fix merge conflict
* Update tests for changes from the merge
* Make UAM notifications unit testable
* Add carb autofill clamping based on the user's carb threshold & max bolus
* Update target order to group extensions together
* Improve issue report description
* Create `MealDetectionManager` from old UAM functions in `CarbStore`
* Move notification logic into `MealDetectionManager`
* Updates based on feedback for UAM PR (#7)
* Create `MealDetectionManager` from old UAM functions in `CarbStore`
* Move notification logic into `MealDetectionManager`
* Move UAM test fixtures from LoopKit to Loop
* Remove old TODO
* Revert change to Loop signing team
* Fix merge issues
* Make tests runnable
* Lower meal carb threshold to 15 g to reduce false-negatives
* Fix carb entry controller merge issues
* Unannounced meal / UAM -> missed meal
* UAM test fixture -> missed meal test fixture
* Variable naming improvements
* Remove `AlertPermissionsViewModel`
* Move call to check for missed meals to `loop()`-level
* Remove `CarbStore` dependency from `MealDetectionManager`
These changes also remove the requirement that there be no carbs entered after the missed meal was detected - since we're now observing direct absorption, I didn't think this requirement made sense anymore
* Reduce `minRecency` required to detect a meal
* Update counteraction effect math in `MealDetectionManager` to skew towards an earlier meal time instead of a later one
* Fix conflict + move missed meal toggle 1 level higher
bjorkert pushed a commit to bjorkert/Loop that referenced this pull request Jun 13, 2023
ps2 pushed a commit that referenced this pull request Jul 2, 2023
* Remote handling rearchitecture
* Move remote background handling to ServicesManager.
Use notification to detect loop completion.
Move handleRemoteNotification to ServicesManager
* Add delegate for ServicesManager
* Remove remote details from DeviceDataManager
* Remove remote terms from ServicesManagerDelegate api
* Respond only to loopFinished notifications
* Remove unused method
* Rename method
* Update names
* Update names
* Remove more remote references in DeviceDataManager
* Remove Remote 2.0 parts
* Update enact override method name
* Move validation to ServicesManager.
Move ServiceManager delegation to LoopDataManager
* Move bolus validation to ServicesManager
taylorpatterson-T1D referenced this pull request in LoopPowerPack/Loop Apr 29, 2026
Implements three programmatic safeguards from Street (2026) "Frontier LLMs
require explicit clinical context to avoid training-data anchoring for
insulin pump settings" (https://www.diabettech.com/wp-content/uploads/2026/04/diabettech_preprint-3.pdf):
1. Bounds clamping (recommendation #2): Values exceeding the max change %
by up to 1.5x are clamped to the limit instead of hard-rejected, with a
logged validation note.
2. Citation verification (recommendation #3): Glucose values cited in AI
reasoning are cross-checked against the actual hourly averages sent to
the model (±2 mg/dL tolerance). Misattribution rate is reported as a
validation note.
3. Confidence adjustment by data availability: CR analysis with <5 meals or
ISF analysis with <3 corrections is capped at Low confidence with an
explicit warning about anchor substitution risk. Basal (the most data-
driven setting per Street's anchoring spectrum) is not capped.
All changes are in the response parsing layer — no prompt modifications:
- LoopInsights_AIAnalysis.swift: parseResponse() + extractCitedGlucoseValues()
- LoopInsights_Models.swift: validationNotes field on LoopInsightsAnalysisResponse
- LoopInsights_DashboardView.swift: validation notes display in UI
threecee pushed a commit to threecee/Loop that referenced this pull request May 2, 2026
… (B.4 LoopKit#3)
Three changes that together close Issue LoopKit#3 from the post-Build-859
critical review:
1. Watch-side WatchSettingsSnapshot.init(fromSync:) now reads
automaticDosingEnabled + isAutomaticDosingAllowed from the sync
payload (?? false) instead of hardcoding false.
2. iOS-side LoopAppManager now constructs HandoffOrchestrator with a
settingsSyncProvider closure. Without this, the orchestrator's
emitSettingsSync() returned at the `guard let provider` check, so
the entire Phase 6 sync emission was dead code in production. The
field-add in OmniBLE (commit 5c86787) is worthless without this
wiring.
3. Adds new test for automaticDosing field passthrough (iOS-emitter
side) and field reception (watch-consumer side).
Together with the OmniBLE-side struct extension, the watch can now
actually run as a closed-loop driver when the phone has automatic
dosing enabled.
threecee-claude
threecee pushed a commit to threecee/Loop that referenced this pull request May 2, 2026
Three fixes from code review of 37b1535:
CRITICAL — maximumBolus / maximumBasalRatePerHour now follow the same
fail-closed semantic as missing schedules: nil → suppress emission via
return nil (let the watch keep its cached sync). Previously `?? 0`
would actively send "max bolus = 0" / "max basal = 0" to a freshly-
paired watch with no cache, which the algorithm would interpret as a
hard cap of zero — silently disabling all dosing rather than waiting
for real settings.
IMPORTANT — TODO marker added for the nightscoutConfig: nil stub. When
the watch runs as algorithm driver it loses Nightscout integration
until RemoteDataServicesManager is wired (B.5 or later). The TODO
makes this discoverable to future grep audits.
IMPORTANT — Added testInitFromSyncReadsAutomaticDosingDisabledWhenFalse
reception test. The existing v1-fallback test would still pass if a
future regression flipped the operator from `?? false` to `?? true`
(because nil ?? true == true would look like the v1 path returning
true). The explicit false → false test locks in the safety-critical
operator semantics on the watch.
threecee-claude
threecee pushed a commit to threecee/Loop that referenced this pull request May 2, 2026
…er (B.5.2 #5b/LoopKit#3/#3b)
Phase 4 of B.5.2 — wire the iOS side to the OmniBLE-side primitives added
in Phases 1–3:
* Issue #5b — friendly UI rendering when the OmniBLE command gate fires.
- NEW: HandoffBlockedError (LocalizedError) at Loop/Managers/WatchHandoff/
with one .handoffInProgress case + friendly description.
- StatusTableViewController.presentErrorCancelingBolus now substitutes
the friendly message when the underlying error is
PumpManagerError.uncertainDelivery AND HandoffOrchestrator.shared's
ownership.commandsAllowed is false (the gate's signal).
* Issue LoopKit#3 — populate sync.timeZone at emission and resolve a scheduleZone
on the watch side.
- LoopAppManager.makeWatchSettingsSync passes
timeZone: TimeZone.current.identifier when constructing the sync.
- WatchAlgorithmKit/WatchAlgorithmDriver's WatchSettingsSnapshot
init(fromSync:) resolves a scheduleZone from sync.timeZone (with
fallback to the watch's TimeZone.current for v3 senders or unknown
identifiers) and threads it to all 4 schedule constructors
(basal, ISF, carb ratio, glucose target).
* Issue #3b — observe NSSystemTimeZoneDidChange on the phone.
- HandoffOrchestrator (iOS) installs a closure-based observer in init
that calls notifySettingsChanged() on every system-TZ-change event,
so the watch picks up the new identifier within a sync round-trip
instead of lagging until some other settings change. Token-based
removal in deinit (closure observers are not removed by
removeObserver(self)).
Tests:
- LoopTests/WatchHandoff/SettingsSyncEmissionTests: +2
(testOutboundSyncIncludesTimeZoneFromCurrent,
testSystemTimeZoneDidChangeNotificationTriggersFreshEmission) — 7/7 pass
- WatchApp ExtensionTests/WatchAlgorithmDriverTests: +2
(testScheduleZoneDerivedFromSyncTimeZone,
testScheduleZoneFallsBackToCurrentWhenSyncTimeZoneNil) — 11/11 pass.
Added `import OmniBLE` for PhoneWatchSettingsSync.
- WatchApp ExtensionTests/Phase6_SettingsSyncReceptionTests: +1
(testTimeZoneRoundTripsThroughCache) — 8/8 pass
- Full WatchApp ExtensionTests scheme: 89/89 pass
LoopWorkspace iOS build: SUCCEEDED.
12 pre-existing locale-dependent test failures in BolusEntryViewModelTests
+ SimpleBolusViewModelTests are unrelated to this change (US-vs-Danish
decimal separator and AM/PM-vs-24h formatting) and reproduce on the
parent commit.
threecee-claude
jeremybarnum pushed a commit to jeremybarnum/Loop that referenced this pull request Jul 10, 2026
…ts on temp-over-temp)
Changing an active temp from the watch faulted bench pod LoopKit#2 terminally
(0x31 -> critical fault 049): PodProofKit.setTempBasal programmed a temp
while one was running. Stock OmniBLE always safe-cancels a possibly-running
temp first (enactTempBasal, OmniBLEPumpManager.swift:2104-2136) and guards
against temping during a bolus or while suspended; the facade skipped all
three because the EMULATOR accepts overlapping temps.
setTempBasal now mirrors the stock idiom: cancelDelivery(.tempBasal) first
(plumbing, not journaled; the new .tempBasal event closes the prior segment
in the net-basal math), then the bolusing/suspended guards, then the program.
Full incident + pod LoopKit#3 test matrix in WATCH_LOAN_TESTING_BUGS.md BUG-6.
Build-verified: PodSDK + full LoopWorkspace scheme.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeremybarnum pushed a commit to jeremybarnum/Loop that referenced this pull request Jul 17, 2026
The Sport Mode meal-bolus recommendation anchored on the newest stored
reading with no age check, and fabricated a 100 mg/dL placeholder when no
sample existed - the one place a number gets crown-confirmed into insulin
had no equivalent of stock's glucoseTooOld gate (review C12). Scenario: a
45-min G7 gap leaves 180 mg/dL as the newest sample while actual BG has
fallen to 90; the flow pre-loads a correction-included dose from the stale
180.
Now the same gate the auto-loop uses (predictionStore.isAnchorStale, stock
inputDataRecencyInterval = 15 min): a missing or stale anchor produces NO
recommendation - the dial starts at zero with no suggested dose, matching
the phone's stale-data behavior. Placeholder BG deleted. Carbs still log;
manual dosing on the user's own judgment still works.
Approved by Jeremy (fix batch LoopKit#3). watchOS build verified.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jeremybarnum pushed a commit to jeremybarnum/Loop that referenced this pull request Jul 25, 2026
…Kit#1/LoopKit#3)
Field diagnosis of three concerns after the addPumpEvents reroute:
LoopKit#3 (eventual 76 shows temp "0" that reads as no-action): NOT a dosing bug — the
loop correctly low-temps to 0 U/hr for a below-target eventual. The defect is
display: the glance rendered the ABSOLUTE temp rate with a forced sign ("%+.2f" of
dose.unitsPerHour), so a reduction could never read negative and a suspend showed
"+0.00". Fix: show NET (temp − scheduled), matching stock's net-basal convention
and publishHUDContext:324 — now + is above schedule, − a reduction, 0 at schedule.
LoanDebugController: render an absent temp as "none (scheduled)" instead of a fake
"0.00 U/hr" so a real 0 U/hr suspend is distinguishable. Add the predicted MIN and
suspend threshold to the per-cycle [predict] line so eventual/min/threshold/rec are
readable on one line.
LoopKit#1 (handover IOB ~0.3U bump): instrument the leading suspect — the running temp is
seeded twice at takeover (once inside grant.doseHistory, once as boundaryRecord),
and the watch IOB path doesn't reconcile overlaps. New boundaryDuplicatesHistory()
+ SEED-IN log line reports the seed record count, grossImpliedΣ, and a boundaryDup
flag that fires when a doseHistory temp overlaps the boundaryRecord at equal rate —
the double-seed signature. One takeover confirms or kills it; the fix (dedup) waits
for that confirmation.
All watch-side, low-risk; no dosing logic changed. Instrumentation is greppable
([loan]/[predict]).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeremybarnum pushed a commit to jeremybarnum/Loop that referenced this pull request Jul 26, 2026
…oopKit#35/LoopKit#3/LoopKit#46)
LoopKit#35 (phone silently fails to ack hand-back offers → watch retries → feels hung): the
phone doesn't mirror to iCloud, so its offer handling was a black box. Add a .diag
LoanMessage the phone relays and the watch logs to iCloud as [phone]. The phone now
breadcrumbs handleHandbackOffer: "offer RX" (received + event count + state), "write
START", and "write DONE <ms> → ACK" / "write FAILED". So a silent phone now shows
whether it received the offer and whether the addPumpEvents write stalled the ack.
LoopKit#3/LoopKit#46 prediction inputs: [momentum] logs effect Δ, point count, and latest-glucose
age; [rc] logs the active RC type (Standard vs Integral, LoopKit#46) + discrepancy count + net.
Tests: .diag added to round-trip + epoch tests; controller harness filters .diag so
breadcrumbs don't pollute sent/expectations. 26/26 pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@loudnate