Skip to content

New strategy for asset overrides. Fixes popup warnings - #4

Merged
ps2 merged 1 commit into
devfrom
asset-overrides
Oct 13, 2019
Merged

New strategy for asset overrides. Fixes popup warnings#4
ps2 merged 1 commit into
devfrom
asset-overrides

Conversation

@ps2

@ps2ps2 commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@ps2
ps2 merged commit ba37e40 into devOct 13, 2019
ps2 added a commit that referenced this pull request Dec 31, 2019
Override feature flags, bundle id, and app name
@ps2
ps2 deleted the asset-overrides branch May 19, 2020 02:39
ddaniels1 pushed a commit to ddaniels1/LoopWorkspace that referenced this pull request May 23, 2020
* Move mock health data deletion to Loop
* Fix mock data deletion section logic
treed6386 added a commit to treed6386/LoopWorkspace that referenced this pull request Jan 7, 2024
codebymini pushed a commit to codebymini/LoopWorkspace that referenced this pull request Sep 2, 2025
threecee pushed a commit to threecee/LoopWorkspace that referenced this pull request May 2, 2026
Picks up:
- OmniBLE (b5-start..HEAD, 4 commits): commandsAllowed gate flag on
OmniBLEOwnership + callback-based gate in OmniBLEPumpManager
enactBolus/enactTempBasal (#1); claimedOwner field on
PhoneWatchHeartbeat + PhoneWatchProtocol.currentVersion 2 -> 3 (LoopKit#5);
HandoffStatePersistence + state machine restore-on-init (LoopKit#4);
command-gate integration sub-test in WatchAlgorithmEndToEndTests.
- Loop (b5-start..HEAD, 4 commits): orchestrator effect cases wire
ownership.commandsAllowed flips on both iOS + watch (#1); both
PhoneWatchSessionCoordinators populate claimedOwner in heartbeats
+ watch demotes itself silently on split-brain detection (LoopKit#5);
watch pump manager construction reads from WatchSettingsCache
instead of .watchSideDefault (LoopKit#7); WatchDoseRecoveryStore tripwire
in WatchAlgorithmKit + ExtensionDelegate launch-time stale check;
test pollution fix on iOS + watch HandoffOrchestratorTests +
SettingsSyncEmissionTests + protocol version assertion bump.
After this, the audit gaps from the B.4 critical review are closed:
- Real protection during handoff transitions (no mid-handoff double-
command races)
- Split-brain detection with phone-wins arbitration
- Crash recovery via persistence (HandoffState survives app restart)
+ dose-in-flight tripwire on watch
- Watch pump manager uses real settings, not hardcoded defaults
BEHAVIOR: The new gate and split-brain demotion will fire when expected
(forced handoffs, transient WCSession glitches). Worth observing on
hardware install of next build.
Verified:
- OmniBLETests targeted: all suites green incl. WatchAlgorithmEndToEndTests 5/5
- LoopTests targeted: all green (HandoffOrchestratorTests 13/13,
HandoffPolicyEngineTests 11/11, SettingsSyncEmissionTests 5/5)
- WatchApp ExtensionTests targeted: all green (33/33 across 4 suites)
- Release archive: ARCHIVE SUCCEEDED (iOS, generic destination)
threecee-claude
threecee pushed a commit to threecee/LoopWorkspace that referenced this pull request May 4, 2026
DriverTokenRendezvous Codable type with HMAC-SHA256 signing
(CryptoKit). HandoffOrchestrator gains buildSignedRendezvous()
method that constructs + signs the rendezvous from the App Group
APNs token store (B.11.0), guarded by the existing isCurrentDriver
gate (B.11.1 driver-only-writes invariant). Empty Nightscout API
secret degrades to empty signature with debug-log warning (spec
Risks LoopKit#4). End-to-end token-rotation propagation tests in Loop
exercise the B.11.0 -> B.11.2 producer chain.
Production splice into Nightscout devicestatus
(loop.testingDetails.driverToken — riding LoopStatus.testingDetails
since LoopStatus is in external NightscoutKit and adding a sibling
key would require forking it) is deferred to B.11.2.1 since the
slice scope per Carl's instruction was Loop + OmniBLE submodules
only. Producer side (orchestrator-side build + sign) fully
implemented and tested.
Algorithm-fidelity-audit: PASS (Class A/B — additive metadata).
No algorithm-output path touched.
Tagged b11.2-complete on all three repos. Build 886 prep.
threecee-claude
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ps2