Uh oh!
There was an error while loading. Please reload this page.
merging - #5
Closed
lolos2go wants to merge 6 commits into
Closed
Conversation
ddaniels1 pushed a commit
to ddaniels1/LoopWorkspace
that referenced
this pull request
May 23, 2020
* Limit recommended temp basals to supported rates. * Use pumpmanager provided rounding * Fix tests, and update to PumpManager function name change * Update naming from review comments
bjornoleh referenced
this pull request
in bjornoleh/LoopWorkspace
Sep 29, 2021
Update submodule rileylink_ios: Xcode 13 updates
codebymini pushed a commit
to codebymini/LoopWorkspace
that referenced
this pull request
Sep 2, 2025
threecee pushed a commit
to threecee/LoopWorkspace
that referenced
this pull request
May 2, 2026
Picks up: - OmniBLE (b5-start..HEAD, 4 commits): commandsAllowed gate flag on OmniBLEOwnership + callback-based gate in OmniBLEPumpManager enactBolus/enactTempBasal (#1); claimedOwner field on PhoneWatchHeartbeat + PhoneWatchProtocol.currentVersion 2 -> 3 (LoopKit#5); HandoffStatePersistence + state machine restore-on-init (LoopKit#4); command-gate integration sub-test in WatchAlgorithmEndToEndTests. - Loop (b5-start..HEAD, 4 commits): orchestrator effect cases wire ownership.commandsAllowed flips on both iOS + watch (#1); both PhoneWatchSessionCoordinators populate claimedOwner in heartbeats + watch demotes itself silently on split-brain detection (LoopKit#5); watch pump manager construction reads from WatchSettingsCache instead of .watchSideDefault (LoopKit#7); WatchDoseRecoveryStore tripwire in WatchAlgorithmKit + ExtensionDelegate launch-time stale check; test pollution fix on iOS + watch HandoffOrchestratorTests + SettingsSyncEmissionTests + protocol version assertion bump. After this, the audit gaps from the B.4 critical review are closed: - Real protection during handoff transitions (no mid-handoff double- command races) - Split-brain detection with phone-wins arbitration - Crash recovery via persistence (HandoffState survives app restart) + dose-in-flight tripwire on watch - Watch pump manager uses real settings, not hardcoded defaults BEHAVIOR: The new gate and split-brain demotion will fire when expected (forced handoffs, transient WCSession glitches). Worth observing on hardware install of next build. Verified: - OmniBLETests targeted: all suites green incl. WatchAlgorithmEndToEndTests 5/5 - LoopTests targeted: all green (HandoffOrchestratorTests 13/13, HandoffPolicyEngineTests 11/11, SettingsSyncEmissionTests 5/5) - WatchApp ExtensionTests targeted: all green (33/33 across 4 suites) - Release archive: ARCHIVE SUCCEEDED (iOS, generic destination) threecee-claude
threecee pushed a commit
to threecee/LoopWorkspace
that referenced
this pull request
May 4, 2026
Lifts 5 iOS<->watch duplicated handoff-stack files into OmniBLE/Common parameterized by HandoffRole: ShadowStateScheduler, PhoneWatchTransport, PhoneWatchSessionCoordinator + HeartbeatScheduler, HandoffPolicyEngine, HandoffOrchestrator. Adds HandoffStack.assemble(role:) factory that deduplicates LoopAppManager + ExtensionDelegate bootstrap chains. ~2,675 LOC reduction in Loop submodule (dedup); +1,500 LOC in OmniBLE/Common (single source of truth, with role-conditional behavior folded into the lifted types). Tests deduplicated: 76 -> 51 paired methods, all green. Phase 8 adds 3 HandoffStack factory tests (phone/watch/reentrancy). Drive-by re-add of WatchApp ExtensionTests/PhoneWatchTransportMock.swift (deleted in Phase 6 but still referenced by watch-only WatchPumpManagerSettingsTests - pre-existing watch-test-target build regression that B.10 closes). algorithm-fidelity-audit PASS (Class A pure structural). Closes /simplify quality #1 + LoopKit#5. Report: /tmp/algorithm-fidelity-audit-2026-05-04-b10.md. Tagged b10-complete on Loop, OmniBLE, and LoopWorkspace. Build 880 prep. Recommend HV-1 within 2 weeks of ship to verify no subtle handoff regressions in real-hardware paths. threecee-claude
loopkitdev pushed a commit
that referenced
this pull request
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.