Skip to content

fix: preserve RMSD reference after reconnect - #71

Open
vvsrinath wants to merge 2 commits into
MDAnalysis:mainfrom
vvsrinath:main
Open

fix: preserve RMSD reference after reconnect#71
vvsrinath wants to merge 2 commits into
MDAnalysis:mainfrom
vvsrinath:main

Conversation

@vvsrinath

Copy link
Copy Markdown

This PR preserves the RMSD reference when the dashboard reconnects.

Previously, _update_selection() always replaced reference_positions with the current positions of the newly connected Universe. This caused the RMSD reference to change after reconnecting.

The implementation adds reset_reference to _update_selection(). Reconnection uses reset_reference=False, preserving the existing reference, while changing the RMSD selection continues to reset the reference.

Added a regression test covering the reconnect scenario.

Focused test result: 5 passed, 68 deselected.

The remaining test-suite issue appears to be related to an environment dependency and is being investigated separately.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 mdadash | 🛠️ Build #34184553 | 📁 Comparing a1d1b1f against latest (5780a37)

🔍 Preview build

1 file changed
±_modules/mdadash/backend/analyses/rmsd.html

@codecov

codecovBot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5780a37) to head (a1d1b1f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
ComponentsCoverage Δ
frontend100.00% <ø> (ø)
backend100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@vvsrinath