Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Add example for using multiple features in code-blocks by Tejas2805 · Pull Request #1102 · MarkBind/markbind · GitHub
Skip to content

Add example for using multiple features in code-blocks - #1102

Merged
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example
Mar 11, 2020
Merged

Add example for using multiple features in code-blocks#1102
marvinchin merged 10 commits into
MarkBind:masterfrom
Tejas2805:code-blocks-example

Conversation

@Tejas2805

@Tejas2805Tejas2805 commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Fixes#1098

What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.

What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.

Provide some example code that this change will affect:
N.A.

Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Can check the deployed preview.

Proposed commit message: (wrap lines at 72 characters)

The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.

Tejas2805and others added 6 commits February 17, 2020 04:54
* 'master' of https://github.com/MarkBind/markbind:
Update tests
Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
Support line numbers for code blocks (MarkBind#991)
2.11.0
Update test files due to changes in PR MarkBind#982
Update vue-strap version to v2.0.1-markbind.36
Make highlighting bold (MarkBind#1045)
Support markdown for header attr in dropdown (MarkBind#1029)
Add '_site' to the ignored folders in site.json (MarkBind#1046)
Use path.join instead of string interpolation (MarkBind#1052)
Implement box markdown header attributes parsing (MarkBind#1025)
Make the position of top navbar fixed (MarkBind#982)
Exclude *.md files from being copied over on build (MarkBind#1010)
# Conflicts:
#	docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind:
2.12.0
Update outdated test files
Update vue-strap version to v2.0.1-markbind.37
Fix refactor to processDynamicResources (MarkBind#1092)
Implement lazy page building for markbind serve (MarkBind#1038)
Add warnings for conflicting/deprecated component attribs (MarkBind#1057)
Allow changing parameter properties (MarkBind#1075)
Custom timezone for built-in timestamp (MarkBind#1073)
Fix reload inconsistency when updating frontmatter (MarkBind#1068)
Implement an api to ignore content in certain tags (MarkBind#1047)
Enable AppVeyor CI (MarkBind#1040)
Add heading and line highlighting to code blocks (MarkBind#1034)
Add dividers and fix bug in siteNav (MarkBind#1063)
Fixed navbar no longer covers modals (MarkBind#1070)
Add copy code-block plugin (MarkBind#1043)
Render plugins on dynamic resources (MarkBind#1051)
Documentation for Implement no-* attributes for <box> (MarkBind#1042)
Migrate to bootstrap-vue popovers (MarkBind#1033)
Refactor preprocess and url processing functions (MarkBind#1026)
Add pageNav to Using Plugins Page (MarkBind#1062)
@Tejas2805Tejas2805 changed the title [WIP]Code blocks exampleAdd example for using multiple features in code-blocksMar 9, 2020
@Tejas2805

Copy link
Copy Markdown
ContributorAuthor

@marvinchin Can I get your review on this. Thank you for your time.

@Tejas2805
Tejas2805 marked this pull request as ready for review March 9, 2020 07:01

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation update. All is good except for the fact there are no commas.

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Tejas2805and others added 3 commits March 9, 2020 23:12
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
@Tejas2805
Tejas2805 requested a review from nbriannlMarch 9, 2020 15:28

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit. 😅

Comment threaddocs/userGuide/syntax/code.mbdf Outdated
Comment threaddocs/userGuide/syntax/code.mbdf Outdated

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for raising up that you couldn't understand how to use multiple features.

@marvinchinmarvinchin added this to the v2.12.1 milestone Mar 11, 2020
@marvinchin
marvinchin merged commit d409741 into MarkBind:masterMar 11, 2020
@Tejas2805
Tejas2805 deleted the code-blocks-example branch March 13, 2020 10:01
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Mar 15, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks.
Let's add an example regarding how to use multiple features in code
blocks so that it's easier for the user to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use multiple features for code blocks

3 participants

@Tejas2805@marvinchin@nbriannl