[FIX] Inconsistent data types and validations

[gantunesr]

Description

The TS refactor and workflow update had issues that prevented the module to be correctly published and consumed by the clients, this PR aims to solve them.

The noticeable issues were,

1. The method fullUpdate was marked as private when it should be public.
2. The method normalizeToHex is returning a string to methods that require a Hex.
3. The data type validation for the parameter data in the #newKeyring was removed because the clients are not sending the correct input. The validation will be re-introduced after the proper updates in the clients.
4. The tsconfig.build.json file was update in accordance to the module template.
5. the .d.ts files were misplaced in the wrong directory

Changes

• CHANGED:
  • The methods that consume the method normalizeToHex have to cast the return type as Hex.
  • The method #newKeyring removed a data validation because of the data param input from the clients.
  • The method fullUpdate was mistakenly flagged as private, this PR introduces it again as public.

References

• BREAKING: TS Refactor #202
• Improve build-lint-test workflow #221

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[legobeat]

BREAKING:
The method fullUpdate was mistakenly flagged as private, this PR introduces it again as public.

nit but I don't think that would be breaking either way? Making it private from public would have been.

[legobeat]

@gantunesr How can I replicate the release-blocking issue that this addresses locally in order to review the fix?

[gantunesr]

@legobeat good point!

How can I replicate the release-blocking issue that this addresses locally in order to review the fix?

I'm not sure about the exact problem that led to the error in NPM publishing. I was reviewing the previous workflow but didn't find any logs pertaining to the issue. Previously, I encountered errors concerning the yarn build command and encountered some typescript problems with the clients. @Gudahtt, do you have any suggestions on how we can ensure that the publish workflow is functioning correctly?

[Gudahtt]

Try comparing the module template publishing workflow with the one used here. The problem was that the build step was missing entirely - it didn't malfunction, it was just never included.

I don't think it relates to the changes in this PR though, we can fix the workflows separately.

[gantunesr]

@Gudahtt@legobeat I have opened a new PR (#230) to update the module configuration to match the one from https://github.com/MetaMask/metamask-module-template

[legobeat]

LGTM

[paulmillr]

any updates on this one?

[gantunesr]

@paulmillr I'll run a test now and if it succeeds it should be good to go

[paulmillr]

@gantunesr tests seems to pass

[gantunesr]

@paulmillr I was referring to the unit and E2E tests in the MetaMask client, they're failing due to the error management updates. I'm working on fixing them

[paulmillr]

Is timing for v11 release known?

[legobeat]

Is timing for v11 release known?

@metamask/eth-keyring-controllerv11.0.0 has been released: https://github.com/MetaMask/KeyringController/releases/tag/v11.0.0