Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Update module configuration - #230

Merged
gantunesr merged 15 commits into
mainfrom
configuration
May 19, 2023
Merged

Update module configuration#230
gantunesr merged 15 commits into
mainfrom
configuration

Conversation

@gantunesr

Copy link
Copy Markdown
Member

Description

This PR updates the general configuration of the KeyringController to module to match the ones from https://github.com/MetaMask/metamask-module-template.

@gantunesrgantunesr added the team-accounts This should be handled by the Accounts Team label May 17, 2023
@socket-security

socket-securityBot commented May 17, 2023

Copy link
Copy Markdown

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    Ignoring: @lavamoat/preinstall-always-fail@1.0.0, commander@9.5.0, jest-it-up@2.2.0, @inquirer/core@0.0.15-alpha.0, cli-width@3.0.0, ansi-colors@4.1.3

    Pull request alert summary
    IssueStatus
    Critical CVE✅ 0 issues
    CVE✅ 0 issues
    Mild CVE✅ 0 issues
    Install scripts✅ 0 issues
    Native code✅ 0 issues
    Bin script confusion✅ 0 issues
    Bin script shell injection✅ 0 issues
    Filesystem access✅ 0 issues
    Network access✅ 0 issues
    Shell access✅ 0 issues
    Unresolved require✅ 0 issues
    Invalid package.json✅ 0 issues
    HTTP dependency✅ 0 issues
    Git dependency✅ 0 issues
    GitHub dependency✅ 0 issues
    No bug tracker✅ 0 issues
    No contributors or author data✅ 0 issues
    No README✅ 0 issues
    Deprecated✅ 0 issues
    New author✅ 0 issues
    Unstable ownership✅ 0 issues
    Non-existent author✅ 0 issues
    Unmaintained✅ 0 issues
    Unpublished package✅ 0 issues
    Potential typo squat✅ 0 issues
    Known Malware✅ 0 issues
    Telemetry✅ 0 issues
    Protestware/Troll package✅ 0 issues
    AI detected security risk✅ 0 issues
    AI warning✅ 0 issues

    📊 Modified Dependency Overview:

    ➕ Added PackageCapability Access+/- Transitive CountPublisher
    @lavamoat/preinstall-always-fail@1.0.0None+0kumavis
    jest-it-up@2.2.0filesystem, shell, environment+9rbardini

    @gantunesr

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore-all

    Comment threadpackage.json Outdated
    Comment threadpackage.json Outdated
    Comment threadtsconfig.json Outdated
    Comment threadtsconfig.json
    Comment thread.github/workflows/build-lint-test.yml Outdated
    Comment thread.github/workflows/build-lint-test.yml Outdated
    Comment thread.github/workflows/build-lint-test.yml Outdated
    @gantunesr
    gantunesr marked this pull request as ready for review May 18, 2023 01:05
    @gantunesr
    gantunesr requested a review from a team as a code ownerMay 18, 2023 01:05
    Comment thread.yarn/releases/yarn-3.2.1.cjs
    Comment thread.yarn/plugins/@yarnpkg/plugin-constraints.cjs
    Comment thread.github/pull_request_template.md Outdated
    Comment thread.github/pull_request_template.md Outdated
    legobeat
    legobeat previously approved these changes May 19, 2023

    @legobeatlegobeat left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Two nit-suggestions on the PR template. Address those and looks good to go 👍

    Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
    Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
    @gantunesr
    gantunesr requested a review from legobeatMay 19, 2023 14:47
    @gantunesr
    gantunesr merged commit b9a600a into mainMay 19, 2023
    @gantunesr
    gantunesr deleted the configuration branch May 19, 2023 21:28
    Comment thread.github/workflows/main.yml
    Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

    Labels

    team-accountsThis should be handled by the Accounts Team

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @gantunesr@Gudahtt@legobeat