Skip to content

rename network controller properties state property - #1074

Merged
cryptodev-2s merged 1 commit into
mainfrom
rename-network-controller-properties-state
Jan 30, 2023
Merged

rename network controller properties state property#1074
cryptodev-2s merged 1 commit into
mainfrom
rename-network-controller-properties-state

Conversation

@cryptodev-2s

Copy link
Copy Markdown
Contributor

This PR renames properties network controller state property to networkDetails.
Related issue #1019

@cryptodev-2s
cryptodev-2s requested a review from a team as a code ownerJanuary 23, 2023 16:36
mcmire
mcmire previously approved these changes Jan 23, 2023

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Gudahtt

This comment was marked as resolved.

Base automatically changed from improve-network-controller-unit-tests to mainJanuary 24, 2023 16:25
@Gudahtt

This comment was marked as resolved.

@cryptodev-2s
cryptodev-2sforce-pushed the rename-network-controller-properties-state branch from ba0d6e6 to e51c954CompareJanuary 25, 2023 13:58
@cryptodev-2s

Copy link
Copy Markdown
ContributorAuthor

Base PR now merged; this should be ready to review once rebased onto main

PR has been rebased onto main

Gudahtt
Gudahtt previously approved these changes Jan 25, 2023

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcmire
mcmire previously approved these changes Jan 25, 2023

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@cryptodev-2s
cryptodev-2s dismissed stale reviews from mcmire and Gudahtt via a2d88a7January 25, 2023 16:47
@cryptodev-2s
cryptodev-2sforce-pushed the rename-network-controller-properties-state branch from e51c954 to a2d88a7CompareJanuary 25, 2023 16:47
Gudahtt
Gudahtt previously approved these changes Jan 25, 2023
mcmire
mcmire previously approved these changes Jan 26, 2023
@cryptodev-2s
cryptodev-2s dismissed stale reviews from mcmire and Gudahtt via e36e986January 30, 2023 14:26
@cryptodev-2s
cryptodev-2sforce-pushed the rename-network-controller-properties-state branch from a2d88a7 to e36e986CompareJanuary 30, 2023 14:26
@Gudahtt

Copy link
Copy Markdown
Member

@cryptodev-2s FYI if you use the "Update branch" button on GitHub, it will preserve any PR approvals. Rebasing manually requires re-approving.

@cryptodev-2s
cryptodev-2s merged commit 5ed1bd3 into mainJan 30, 2023
@cryptodev-2s
cryptodev-2s deleted the rename-network-controller-properties-state branch January 30, 2023 15:36
@mcmiremcmire mentioned this pull request Feb 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetworkController API normalization: rename properties state to networkDetails

3 participants

@cryptodev-2s@Gudahtt@mcmire