Uh oh!
There was an error while loading. Please reload this page.
Eliminate console error when running test - #1179
Merged
Gudahtt merged 3 commits intoApr 14, 2023
Merged
Conversation
The network client test "queues requests while a previous identical call is still pending..." was emitting a console error due to an unmocked block tracker network call. That call is now mocked, eliminating the error. I am unsure why the second call is made during this test, but we suspect that it's because the first block tracker call isn't being cached until after the RPC call that triggered it has been resolved. To reproduce, use `.only` on that test and run this command: `yarn workspace @metamask/network-controller jest --coverage=false --verbose=false` Before this change, that command should produce console errors. After this change, there will be none (though there are still lots of warnings). This relates to #1178
Gudahttforce-pushed
the
eliminate-network-client-queued-request-test-console-error
branch
from
April 13, 2023 22:06
f4b86aa to
5bb68f8CompareGudahtt
commented
Apr 13, 2023
| for (const paramIndex of [...Array(numberOfParameters).keys()]) { | ||
| it(`does not reuse the result of a previous request if parameter at index "${paramIndex}" differs`, async () => {// eslint-disable-line | ||
| it(`does not reuse the result of a previous request if parameter at index "${paramIndex}" differs`, async () => { |
MemberAuthor
There was a problem hiding this comment.
My editor removed this when I formatted the document. I'm not sure why it was there in the first place, but it appears to have been unnecessary.
Gudahtt
marked this pull request as ready for review
April 13, 2023 22:54
Gudahtt
commented
Apr 14, 2023
MemberAuthor
I found one more error in the equivalent test for methods that do have a block param. I have verified locally that these are the only unmocked network calls in the network controller tests. |
5 tasks
Gudahtt
deleted the
eliminate-network-client-queued-request-test-console-error
branch
April 14, 2023 16:39
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The network client test "queues requests while a previous identical call is still pending..." was emitting a console error due to an unmocked block tracker network call.
That call is now mocked, eliminating the error.
I am unsure why the second call is made during this test, but we suspect that it's because the first block tracker call isn't being cached until after the RPC call that triggered it has been resolved.
To reproduce, use
.onlyon that test and run this command:yarn workspace @metamask/network-controller jest --coverage=false --verbose=falseBefore this change, that command should produce console errors. After this change, there will be none (though there are still lots of warnings).
Changes
N/A
References
This relates to #1178
Checklist