Skip to content

Release 49.0.0 - #1263

Merged
Gudahtt merged 28 commits into
mainfrom
release/49.0.0
Apr 26, 2023
Merged

Release 49.0.0#1263
Gudahtt merged 28 commits into
mainfrom
release/49.0.0

Conversation

@legobeat

@legobeatlegobeat commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Description

Release outstanding changes before bump to nodejs v16.

Changes

approval-controller

controller-utils

ens-controller

keyring-controller

message-manager

network-controller

permission-controller

rate-limit-controller

transaction-controller

References

#1262

Comment threadpackages/permission-controller/CHANGELOG.md Outdated
@legobeat
legobeat marked this pull request as ready for review April 25, 2023 11:38
@legobeat
legobeat requested a review from a team as a code ownerApril 25, 2023 11:38
Comment threadpackages/permission-controller/CHANGELOG.md Outdated
OGPoyraz
OGPoyraz previously approved these changes Apr 25, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Comment threadpackages/ens-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/message-manager/CHANGELOG.md Outdated
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Comment threadpackages/permission-controller/CHANGELOG.md Outdated
Comment threadpackages/transaction-controller/CHANGELOG.md Outdated
Comment threadpackages/transaction-controller/CHANGELOG.md
legobeatand others added 2 commits April 25, 2023 21:39
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Comment threadpackages/network-controller/CHANGELOG.md Outdated
@Gudahtt

Copy link
Copy Markdown
Member

The breaking change in the network controller is also effectively a breaking change for any package that has the network controller as a peer dependency (assets-controllers and gas-fee-controller). We should add an entry to those two package changelogs about this as well, and ensure it's marked as **BREAKING:** with a major version bump.

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Lots of changes in this release, the network controller especially has been in need of a release for some time.

I have finished reviewing these changes, and can approve once all of my comments have been addressed. The last thing I have left to do is review the network controller changelog to see if I can add further detail to explain which changes are breaking, and how to accommodate them when updating. I can revise the changelog post-merge with those changes if necessary though, so it doesn't need to block

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished making suggestions for the network controller changelog

Comment threadpackages/network-controller/CHANGELOG.md
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
legobeatand others added 2 commits April 26, 2023 07:37
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@legobeat

This comment was marked as outdated.

@legobeat

Copy link
Copy Markdown
ContributorAuthor

Updated according to your great feedback @Gudahtt

Comment threadpackages/message-manager/CHANGELOG.md Outdated
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

@FrederikBoldingFrederikBolding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, but would appreciate @Gudahtt sign off too

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Gudahtt merged commit 4cf5dbe into mainApr 26, 2023
@Gudahtt
Gudahtt deleted the release/49.0.0 branch April 26, 2023 11:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat@Gudahtt@OGPoyraz@FrederikBolding