Uh oh!
There was an error while loading. Please reload this page.
Release 49.0.0 - #1263
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
commented
Apr 25, 2023
The breaking change in the network controller is also effectively a breaking change for any package that has the network controller as a peer dependency ( |
Gudahtt
left a comment
There was a problem hiding this comment.
Great work! Lots of changes in this release, the network controller especially has been in need of a release for some time.
I have finished reviewing these changes, and can approve once all of my comments have been addressed. The last thing I have left to do is review the network controller changelog to see if I can add further detail to explain which changes are breaking, and how to accommodate them when updating. I can revise the changelog post-merge with those changes if necessary though, so it doesn't need to block
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
left a comment
There was a problem hiding this comment.
I have finished making suggestions for the network controller changelog
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
legobeat
commented
Apr 26, 2023
Updated according to your great feedback @Gudahtt |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
FrederikBolding
left a comment
There was a problem hiding this comment.
Overall this LGTM, but would appreciate @Gudahtt sign off too
Description
Release outstanding changes before bump to nodejs v16.
Changes
approval-controller
controller-utils
ens-controller
keyring-controller
message-manager
network-controller
rollbackToPreviousProviderasync (MakerollbackToPreviousProviderasync #1237)resetConnectionasync (MakeresetConnectionasync #1239)setProviderTypeunit tests (SimplifysetProviderTypeunit tests #1222)setProviderTypeunit tests (ConsolidatesetProviderTypeunit tests #1221)isCustomNetwork(RemoveisCustomNetwork#1199)networkstate withnetworkIdandnetworkStatus(Replacenetworkstate withnetworkIdandnetworkStatus#1196)upsertNetworkConfigurationasync (MakeupsertNetworkConfigurationasync #1192)setActiveNetworkasync (MakesetActiveNetworkasync #1190)setProviderTypeasync (MakesetProviderTypeasync #1191)refreshNetworkasync (MakerefreshNetworkasync #1182)initializeProviderasync (MakeinitializeProviderasync #1180)verifyNetworkasync (MakeverifyNetworkasync #1181)permission-controller
SubjectMetadataControllerto permission-controller package (BREAKING: MoveSubjectMetadataControllerto permission-controller package #1234)rate-limit-controller
transaction-controller
isCustomNetwork(RemoveisCustomNetwork#1199)networkstate withnetworkIdandnetworkStatus(Replacenetworkstate withnetworkIdandnetworkStatus#1196)References
#1262