Uh oh!
There was an error while loading. Please reload this page.
Remove isCustomNetwork - #1199
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Gudahttforce-pushed
the
remove-is-custom-network
branch
from
April 18, 2023 19:24
96f4fec to
465879cCompareGudahtt
marked this pull request as ready for review
April 18, 2023 19:26
The network controller state `isCustomNetwork` has been removed. This state was redundant; you can determine whether the current selected network is custom or not by checking the `providerConfig` state. The one usage of this state in other packages was the transaction controller. It has been updated to use the provider configuration state instead. Closes#1020
Gudahttforce-pushed
the
remove-is-custom-network
branch
from
April 18, 2023 19:29
465879c to
6acbeb0Comparemcmire
reviewed
Apr 18, 2023
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Just one thing but otherwise looks good.
Uh oh!
There was an error while loading. Please reload this page.
mcmire
approved these changes
Apr 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The network controller state
isCustomNetworkhas been removed. This state was redundant; you can determine whether the current selected network is custom or not by checking theproviderConfigstate.The one usage of this state in other packages was the transaction controller. It has been updated to use the provider configuration state instead.
Changes
isCustomNetworkstateproviderConfig.typeproperty. If it's set toNetworkType.rpcthen it's a custom network, otherwise it's a built-in network.References
Closes#1020
Checklist