Uh oh!
There was an error while loading. Please reload this page.
Consolidate setProviderType unit tests - #1221
Merged
Gudahtt merged 1 commit intoApr 19, 2023
Merged
Conversation
The unit tests for `setProviderType` have been consolidated. They were unnecessarily split between Mainnet and other Infura networks, despite the behavior being identical.
Gudahtt
marked this pull request as ready for review
April 19, 2023 22:05
mcmire
approved these changes
Apr 19, 2023
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Good catch. I'm not sure why I chose to do this originally, but they sure do look the same to me.
Gudahtt
deleted the
consolidate-network-controller-set-provider-type-tests
branch
April 19, 2023 22:26
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The unit tests for
setProviderTypehave been consolidated. They were unnecessarily split between Mainnet and other Infura networks, despite the behavior being identical.Changes
None
References
This was done in pursuit of #1203, though the connection is fairly indirect (I'm on a tangent here)
Checklist