Skip to content

fix changelog - #1232

Merged
bergarces merged 8 commits into
mainfrom
fix-changelog
Apr 20, 2023
Merged

fix changelog#1232
bergarces merged 8 commits into
mainfrom
fix-changelog

Conversation

@bergarces

@bergarcesbergarces commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Description

A previous changelog release had changes left as uncategorized. This PR aims to solve that

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@bergarces
bergarces requested a review from a team as a code ownerApril 20, 2023 10:12
matthewwalsh0
matthewwalsh0 reviewed Apr 20, 2023
View reviewed changes
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
matthewwalsh0
matthewwalsh0 reviewed Apr 20, 2023
View reviewed changes
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Mrtenz
Mrtenz requested changes Apr 20, 2023
View reviewed changes

@MrtenzMrtenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion you can remove any dependency upgrades from the changelog.

Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
bergarcesand others added 6 commits April 20, 2023 11:40
@bergarces@Mrtenz
Update packages/assets-controllers/CHANGELOG.md
d7b7185
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@bergarces@Mrtenz
Update packages/controller-utils/CHANGELOG.md
23922c4
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@bergarces@Mrtenz
Update packages/controller-utils/CHANGELOG.md
814ca7a
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@bergarces@Mrtenz
Update packages/controller-utils/CHANGELOG.md
fee1465
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@bergarces@Mrtenz
Update packages/controller-utils/CHANGELOG.md
6b0db1e
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@bergarces
remove package updates from changelog
2fd147d
@bergarces
bergarces requested a review from MrtenzApril 20, 2023 10:55
@bergarces

bergarces commented Apr 20, 2023

Copy link
Copy Markdown
ContributorAuthor

In my opinion you can remove any dependency upgrades from the changelog.

I've applied the changes and removed the simple version updates. Thanks for the advice.

@bergarces
bergarces merged commit af9bb3c into mainApr 20, 2023
@bergarces
bergarces deleted the fix-changelog branch April 20, 2023 11:15
@legobeatlegobeat mentioned this pull request Apr 25, 2023
Merged
@GudahttGudahtt mentioned this pull request Aug 21, 2023
Merged
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrtenzMrtenzMrtenz approved these changes
@matthewwalsh0matthewwalsh0matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bergarces@Mrtenz@matthewwalsh0