Skip to content

fix: prevent setResult to emit updateBadge but state updates - #1245

Merged
OGPoyraz merged 2 commits into
mainfrom
fix/abstract-mm-update-emit
Apr 21, 2023
Merged

fix: prevent setResult to emit updateBadge but state updates#1245
OGPoyraz merged 2 commits into
mainfrom
fix/abstract-mm-update-emit

Conversation

@OGPoyraz

@OGPoyrazOGPoyraz commented Apr 21, 2023

Copy link
Copy Markdown
Member

Description

This fix makes the setResult function update state but prevents emitting the updateBadge event.

Changes

  • FIXED: Prevent AbstractMM to emit updateBadge but update state

References

This fix needed here: https://github.com/MetaMask/metamask-extension/pull/18379/files#diff-4f0b3f2fec7245e550099cba363f8bed00871b2027fb2d63efd47b2f4aa7c401R247
And patched package in the PR proves that it will fix the issue.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz
OGPoyrazforce-pushed the fix/abstract-mm-update-emit branch from 142e867 to afb7966CompareApril 21, 2023 09:54
@OGPoyrazOGPoyraz changed the title fix: prevent setresult to emit update but statefix: prevent setResult to emit updateBadge but state updatesApr 21, 2023
@OGPoyraz
OGPoyrazforce-pushed the fix/abstract-mm-update-emit branch from afb7966 to 6db4b63CompareApril 21, 2023 10:00
@OGPoyraz
OGPoyraz marked this pull request as ready for review April 21, 2023 10:24
@OGPoyraz
OGPoyraz requested a review from a team as a code ownerApril 21, 2023 10:24
@OGPoyraz
OGPoyraz merged commit ced8c3c into mainApr 21, 2023
@OGPoyraz
OGPoyraz deleted the fix/abstract-mm-update-emit branch April 21, 2023 15:02
@legobeatlegobeat mentioned this pull request Apr 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@OGPoyraz@bergarces