Skip to content

Release 66.0.0 - #1488

Merged
mcmire merged 4 commits into
mainfrom
release/66.0.0
Jul 13, 2023
Merged

Release 66.0.0#1488
mcmire merged 4 commits into
mainfrom
release/66.0.0

Conversation

@legobeat

@legobeatlegobeat commented Jul 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation

References

#1483

See changelogs

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat
legobeat marked this pull request as ready for review July 12, 2023 21:30
@legobeat
legobeat requested a review from a team as a code ownerJuly 12, 2023 21:30
@mcmire

This comment was marked as outdated.

Sign in to view
@mcmiremcmire changed the title Release/66.0.0Release 66.0.0Jul 13, 2023
mcmire
mcmire reviewed Jul 13, 2023
View reviewed changes
Comment threadpackages/keyring-controller/CHANGELOG.md

## [Unreleased]

## [6.1.0]

@mcmiremcmireJul 13, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we think about using 6.0.1 instead of 6.1.0? It seems like this bump is a general upgrade and doesn't enable any explicit features, but I could be wrong.

@GudahttGudahttJul 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I could see it either way. A dependency bump certainly isn't a bug fix - I could see someone updating to get it, similar to how one might update to get a feature. It's kindof a feature for us actually, since it helps reduce the extension bundle size.

@GudahttGudahttJul 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This official answer seems ambiguous to me: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

@mcmiremcmireJul 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, okay. I'll stick with it, then.

Comment threadpackages/message-manager/CHANGELOG.md

## [Unreleased]

## [7.1.0]

@mcmiremcmireJul 13, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar as above — what do we think about 7.0.3?

Gudahtt
Gudahtt approved these changes Jul 13, 2023
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
mcmire merged commit 5a3e28f into mainJul 13, 2023
@mcmire
mcmire deleted the release/66.0.0 branch July 13, 2023 19:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmiremcmiremcmire left review comments
@GudahttGudahttGudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat@mcmire@Gudahtt