Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 300
Release 66.0.0#1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Release 66.0.0 #1488
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | ||
| ## [Unreleased] | ||
| ## [7.1.0] | ||
| ||
| ### Changed | ||
| - Replace eth-sig-util with @metamask/eth-sig-util ([#1483](https://github.com/MetaMask/core/pull/1483)) | ||
| ## [7.0.2] | ||
| ### Fixed | ||
| - Avoid race condition when creating typed messages ([#1467](https://github.com/MetaMask/core/pull/1467)) | ||
| @@ -88,7 +92,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | ||
| All changes listed after this point were applied to this package following the monorepo conversion. | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/message-manager@7.0.2...HEAD | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/message-manager@7.1.0...HEAD | ||
| [7.1.0]: https://github.com/MetaMask/core/compare/@metamask/message-manager@7.0.2...@metamask/message-manager@7.1.0 | ||
| [7.0.2]: https://github.com/MetaMask/core/compare/@metamask/message-manager@7.0.1...@metamask/message-manager@7.0.2 | ||
| [7.0.1]: https://github.com/MetaMask/core/compare/@metamask/message-manager@7.0.0...@metamask/message-manager@7.0.1 | ||
| [7.0.0]: https://github.com/MetaMask/core/compare/@metamask/message-manager@6.0.0...@metamask/message-manager@7.0.0 | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we think about using 6.0.1 instead of 6.1.0? It seems like this bump is a general upgrade and doesn't enable any explicit features, but I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I could see it either way. A dependency bump certainly isn't a bug fix - I could see someone updating to get it, similar to how one might update to get a feature. It's kindof a feature for us actually, since it helps reduce the extension bundle size.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This official answer seems ambiguous to me: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, okay. I'll stick with it, then.