Uh oh!
There was an error while loading. Please reload this page.
Update typescript v4.8 - #1718
Merged
Merged
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
Gudahttforce-pushed
the
update-typedoc
branch
from
September 26, 2023 12:21
1bdd52e to
b28a13bCompareGudahttforce-pushed
the
update-typescript-v4.8
branch
from
September 26, 2023 15:10
13543f4 to
4dbf4d4CompareGudahtt
marked this pull request as ready for review
September 26, 2023 15:11
Gudahttforce-pushed
the
update-typescript-v4.8
branch
from
September 26, 2023 15:51
5dd75b1 to
951bd29CompareMrtenz
previously approved these changes
Sep 26, 2023
MajorLift added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this pull request
Sep 26, 2023
…e monorepo - See MetaMask/core#1718 - See #27 - ClosesMetaMask/core#1682
Gudahtt
commented
Sep 26, 2023
| return { responseData }; | ||
| } catch (error) { | ||
| assertIsError(error); |
MemberAuthor
There was a problem hiding this comment.
The update to v4.8.4 seems to have changed the effective type of this error variable for some reason. It was now triggering a lint error in a function that called this one, due to the @typescript-eslint/no-throw-literal rule (the error was typed as {}, as it was unknown and then we confirmed that it was not falsy).
We now ensure it's explicitly typed as an Error, as we would expect.
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
Mrtenz
approved these changes
Sep 27, 2023
The `typescript` package has been updated to v4.8.4 to align with the module template. This was done to simplify the process of migrating libraries into the monorepo.
Gudahttforce-pushed
the
update-typescript-v4.8
branch
from
September 27, 2023 11:59
498d6db to
38ddf6aCompareMajorLift added a commit
that referenced
this pull request
Sep 27, 2023
…e monorepo - See #1718 - See MetaMask/eth-json-rpc-provider#27 - Closes#1682
33 tasks
3 tasks
legobeat added a commit
that referenced
this pull request
Oct 2, 2023
## Explanation - Bump `@metamask/eslint-config*` packages to latest. - Bump `typedoc`,`typedoc-plugin-missing-exports` to satisfy peerDeps ## References #### Related - #1730 - #1718 ## Changelog ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MajorLift added a commit
that referenced
this pull request
Oct 13, 2023
## Explanation This PR implements the following incremental steps in the process for migrating `eth-json-rpc-provider` into the core monorepo: *** ### Phase B: Staging from `merged-packages/` #### 5. Port tags - See: #1800 <details> <summary>Push ported tags to core repo</summary> - [x] https://github.com/MetaMask/core/releases/tag/@metamask/eth-json-rpc-provider@2.2.0 - [x] https://github.com/MetaMask/core/releases/tag/@metamask/eth-json-rpc-provider@2.1.0 - [x] https://github.com/MetaMask/core/releases/tag/@metamask/eth-json-rpc-provider@2.0.0 - [x] https://github.com/MetaMask/core/releases/tag/@metamask/eth-json-rpc-provider@1.0.1 - [x] https://github.com/MetaMask/core/releases/tag/@metamask/eth-json-rpc-provider@1.0.0 </details> <details> <summary>Verify that the tag diff links in CHANGELOG are working</summary> - [x] **WONTFIX**: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@2.2.0...HEAD - [x] https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@2.1.0...@metamask/eth-json-rpc-provider@2.2.0 - [x] https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@2.0.0...@metamask/eth-json-rpc-provider@2.1.0 - [x] https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@1.0.1...@metamask/eth-json-rpc-provider@2.0.0 - [x] https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@1.0.0...@metamask/eth-json-rpc-provider@1.0.1 </details> ### Phase C: Integration into `packages/` #### 1. The big leap - [x] **Move migration target from `migrated-packages/` to `packages/`.** - [x] Run `yarn install` in the root directory. - [x] Check that all tests are passing in migration target by running `yarn workspace @metamask/<package-name> test`. #### 2. Update downstream repos - [x] Add tsconfig reference paths for migration target in downstream packages and root. - [x] Bump migration target version in downstream packages and root. #### 3. Linter fixes - [x] Apply yarn constraints fixes to migration target package.json file: `yarn constraints --fix` (run twice). - [x] Identify validator fixes for CHANGELOG using `yarn workspace @metamask/<package-name> changelog:validate` and apply the diffs. #### 4. Resolve downstream errors - [x] #1653 - If introducing the migration target breaks any downstream repos: - [x] Resolve simple errors - [x] Mark and ignore complex errors using `@ts-expect-error TODO:` annotations. - [x] Create a separate issue for resolving the marked errors as soon as the migration is completed. #### 5. Finalize merge - [x] Check that all tests are passing in all subpackages of core and CI. - [x] Merge `packages/<package-name>` directory into core main branch. *** See #1551 (comment) for an outline of the entire process. ## Next Steps - The next PR(s) will implement the final steps of the migration process (D-1 in the migration checklist). ## Blocked by - Dependencies: - [x] typescript bump: #1718 - [x] `@metamask/utils` bump: #1639 - Downstream type errors: - [x] #1653 - [ ] MetaMask/eth-json-rpc-provider#14 (ignored) - [ ] MetaMask/utils#140 (ignored) - Tag porting: - [x] #1802 - [x] "Unreleased" tag diff link shows entire history of core: https://github.com/MetaMask/core/compare/@metamask/eth-json-rpc-provider@2.2.0...HEAD ## References - Contributes to #1685 - Contributes to #1551 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/eth-json-rpc-provider` - **ADDED**: Migrated into the core monorepo. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
typescriptpackage has been updated to v4.8.4 to align with the module template. This was done to simplify the process of migrating libraries into the monorepo.References
None
Changelog
N/A
Checklist