devDeps: @metamask/eslint-config*->12.1.0 by legobeat · Pull Request #1740 · MetaMask/core

legobeat · 2023-09-27T23:08:26Z

Explanation

Bump @metamask/eslint-config* packages to latest.
- Bump typedoc,typedoc-plugin-missing-exports to satisfy peerDeps

References

Changelog

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

socket-security · 2023-09-27T23:09:30Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
typedoc-plugin-missing-exports	0.23.0...2.1.0	None	`+25/-50`	30.5 MB	gerrit0
eslint-plugin-import	2.28.1...2.26.0	None	`+2/-49`	1.12 MB	ljharb
typedoc	0.23.28...0.24.8	None	`+0/-25`	1.22 MB	typedoc-bot

Gudahtt

LGTM!

legobeat · 2023-09-28T00:19:29Z

@MetaMask/snaps-devs needs your approval :)

legobeat · 2023-09-28T00:26:03Z

Updated with bumping range for @typescript-eslint/eslint-plugin and @typescript-eslint/parser. 394e3234cd7ac0d7503fa4b3e1f3af949cb09786

These were already at the most recent versions in lockfile so this does not make a difference in practice but done for sake of smooth migrations of other packages into this monorepo.

Mrtenz

Technically unrelated to your change, but we should fix this.

…config peerDep

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

legobeat mentioned this pull request Sep 27, 2023
devDeps: @metamask/eslint-config*->12.1.0 #1523
Closed
4 tasks

legobeat marked this pull request as ready for review September 27, 2023 23:13

legobeat requested review from a team as code owners September 27, 2023 23:13

legobeat added the dependencies Pull requests that update a dependency file label Sep 27, 2023

Gudahtt previously approved these changes Sep 27, 2023
View reviewed changes

legobeat dismissed Gudahtt’s stale review via 394e323September 28, 2023 00:24

legobeat mentioned this pull request Sep 28, 2023
Align ESLint, Prettier packages and configs with core monorepo ahead of migration MetaMask/eth-json-rpc-provider#28
Merged

legobeat requested a review from MajorLift September 28, 2023 00:55

Gudahtt previously approved these changes Sep 28, 2023
View reviewed changes

Mrtenz previously approved these changes Sep 28, 2023
View reviewed changes

Comment threadpackages/transaction-controller/src/TransactionController.test.ts Outdated

legobeat dismissed stale reviews from Mrtenz and Gudahtt via 8826e02September 28, 2023 21:47

legobeat requested review from Gudahtt and Mrtenz September 28, 2023 21:48

MajorLift previously approved these changes Sep 28, 2023
View reviewed changes

legobeat dismissed MajorLift’s stale review via b61aa89September 29, 2023 01:52

legobeat force-pushed the devDeps-typescript-eslint-configs branch from 8826e02 to b61aa89Compare September 29, 2023 01:52

legobeat requested a review from MajorLift September 29, 2023 02:40

legobeat force-pushed the devDeps-typescript-eslint-configs branch from 0c70e96 to 37a3ff7Compare September 29, 2023 04:00

MajorLift previously approved these changes Sep 29, 2023
View reviewed changes

legobeat requested review from a teamSeptember 29, 2023 04:39

Mrtenz previously approved these changes Sep 29, 2023
View reviewed changes

legobeat added 3 commits September 30, 2023 10:47

devDeps: @metamask/eslint-config*->12.1.0
cd9f99c

devDeps: bump typedoc, typedoc-plugin-missing-exports
2c7557c

devDeps: @typescript-eslint/*@^5.30.7->^5.62.0
b791e45

legobeatand others added 7 commits September 30, 2023 10:50

devDeps: @types/node@^16.18.38->^16.18.54
1fd9d6e

devDeps: eslint-plugin-jsdoc@^39.3.3->^39.9.1
363b1f5

devDeps: prettier-plugin-packagejson@^2.2.17->^2.4.5
4893203

devDeps: pin eslint-plugin-import@2.26.0 to satisfy @metamask/eslint-…
c367248
…config peerDep

lint:fix
27ae7d4

Fix relative import of approval-controller in transaction-ontroller
12f9bd3
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

lint:fix
aece1e0

legobeat dismissed stale reviews from MajorLift and Mrtenz via aece1e0September 30, 2023 01:50

legobeat force-pushed the devDeps-typescript-eslint-configs branch from 421869f to aece1e0Compare September 30, 2023 01:50

legobeat requested review from a team, MajorLift and Mrtenz September 30, 2023 01:58

Mrtenz approved these changes Sep 30, 2023
View reviewed changes

Merge branch 'main' into devDeps-typescript-eslint-configs
ff02caf

legobeat requested review from a teamOctober 2, 2023 00:26

legobeat merged commit 53c6b76 into MetaMask:mainOct 2, 2023

legobeat deleted the devDeps-typescript-eslint-configs branch October 2, 2023 00:26

Navigation Menu

Uh oh!

Uh oh!

devDeps: @metamask/eslint-config*->12.1.0 - #1740

devDeps: @metamask/eslint-config*->12.1.0#1740
legobeat merged 11 commits into
MetaMask:mainfrom
legobeat:devDeps-typescript-eslint-configs

legobeat commented Sep 27, 2023

Uh oh!

socket-securityBot commented Sep 27, 2023•
edited
Loading

Uh oh!

Gudahtt left a comment

Uh oh!

legobeat commented Sep 28, 2023

Uh oh!

legobeat commented Sep 28, 2023•
edited
Loading

Uh oh!

Mrtenz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

legobeat commented Sep 27, 2023

Explanation

References

Related

Changelog

Checklist

Uh oh!

socket-securityBot commented Sep 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

legobeat commented Sep 28, 2023

Uh oh!

legobeat commented Sep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mrtenz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

socket-securityBot commented Sep 27, 2023•
edited
Loading

legobeat commented Sep 28, 2023•
edited
Loading