Skip to content

eth-json-rpc-provider migration - B3: Align dependencies with monorepo. - #1766

Merged
MajorLift merged 9 commits into
mainfrom
231003-migrate-eth-json-rpc-provider-b3
Oct 5, 2023
Merged

eth-json-rpc-provider migration - B3: Align dependencies with monorepo.#1766
MajorLift merged 9 commits into
mainfrom
231003-migrate-eth-json-rpc-provider-b3

Conversation

@MajorLift

@MajorLiftMajorLift commented Oct 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation

This PR implements the following incremental step in the process for migrating eth-json-rpc-provider into the core monorepo:

Phase B: Staging in migrated-packages/

3. Align dependencies with monorepo.

  • Remove redundant dependencies that are already listed in the root package.json.
  • Bump remaining dependency versions so that they align with other non-root packages.

See #1551 (comment) for an outline of the entire process.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift
MajorLift requested a review from a team as a code ownerOctober 3, 2023 20:32
@MajorLiftMajorLift mentioned this pull request Oct 3, 2023
Closed
@MajorLiftMajorLift self-assigned this Oct 3, 2023
@socket-security

socket-securityBot commented Oct 3, 2023•
edited
Loading

Copy link
Copy Markdown

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@types/jest28.1.8...28.1.7None+0/-073.2 kBtypes
typedoc0.23.28...0.23.15None+0/-11.02 MBtypedoc-bot

🚮 Removed packages:eslint-plugin-jest@27.1.5, prettier-plugin-packagejson@2.4.5

@MajorLiftMajorLift added enhancement New feature or request dependencies Pull requests that update a dependency file team-wallet-framework Deprecated: Please use `team-core-platform` instead. labels Oct 3, 2023
mcmire
mcmire approved these changes Oct 5, 2023
View reviewed changes

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift
MajorLift merged commit 4b8f6ee into mainOct 5, 2023
@MajorLift
MajorLift deleted the 231003-migrate-eth-json-rpc-provider-b3 branch October 5, 2023 20:33
This was referenced Oct 5, 2023
Merged
Closed
@georgewrmarshallgeorgewrmarshall mentioned this pull request Nov 13, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmiremcmiremcmire approved these changes
@mikespositomikespositoAwaiting requested review from mikesposito
@cryptodev-2scryptodev-2sAwaiting requested review from cryptodev-2s
@kantheshakantheshaAwaiting requested review from kanthesha

Assignees

@MajorLiftMajorLift

Labels

dependenciesPull requests that update a dependency fileenhancementNew feature or requestteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MajorLift@mcmire