Uh oh!
There was an error while loading. Please reload this page.
Assets controller - #18
Conversation
Codecov Report
@@ Coverage Diff @@## master #18 +/- ##
======================================
Coverage 100% 100% ======================================
Files 14 15 +1 Lines 626 770 +144 Branches 73 99 +26 ======================================
+ Hits 626 770 +144
Continue to review full report at Codecov.
|
bitpshr
left a comment
There was a problem hiding this comment.
This is a very strong pull request, I have very little feedback. Really well done. I created MetaMask/website#134 to track stuff around eth-contract-metadata. Feel free to land this whenever you want and I can cut a new release (or show you how to do that as well.)
| * | ||
| * @param address - Hex address of the collectible contract | ||
| * @param tokenId - The NFT identifier | ||
| * @returns - Current collectible list |
There was a problem hiding this comment.
Nit: This may be more accurate if it says "Promise resolving to the current collectible list".
| * @param tokenId - The NFT identifier | ||
| * @returns - Current collectible name and image | ||
| */ | ||
| async requestNFTCustomInformation(address: string, tokenId: number): Promise<CollectibleCustomInformation> { |
There was a problem hiding this comment.
Do you think this method should be public? Will it ever be called externally? Same question for fetchCollectibleBasicInformation. If these methods will only ever be used internally to this controller, I say we make them private to keep the external API as small as possible.
There was a problem hiding this comment.
totally agree, I'll move it
estebanmino
commented
Sep 18, 2018
Thanks @bitpshr. I'll wait for you in order to coordinate the integration to the app as well. |
codecov-io
commented
Sep 18, 2018
Codecov Report
@@ Coverage Diff @@## master #18 +/- ##
======================================
Coverage 100% 100% ======================================
Files 14 15 +1 Lines 626 760 +134 Branches 73 99 +26 ======================================
+ Hits 626 760 +134
Continue to review full report at Codecov.
|
v1.0.1 contains two changes that should have been considered semver-major: - Type-interface incompatability with previous version (MetaMask/json-rpc-engine#139) - Introduced dependency `@metamask/json-rpc-engine` indicates a minimum supported Node.js version of 16. This prevents the module from installing on some package manager configurations, like default yarn classic. This will be re-released as v2.0.0.
Escalate errors on RPC responses
…sk#18) Bumps [@metamask/controllers](https://github.com/MetaMask/controllers) from 16.0.0 to 19.0.0. - [Release notes](https://github.com/MetaMask/controllers/releases) - [Changelog](https://github.com/MetaMask/controllers/blob/main/CHANGELOG.md) - [Commits](MetaMask/core@v16.0.0...v19.0.0) --- updated-dependencies: - dependency-name: "@metamask/controllers" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR adds AssetsController in order to support assets on it. First two assets supported are tokens (ERC20) and collectibles (ERC721).
Related #17
BLOCKER: eth-contract-metadata is not the official, we should decide what to do with collectibles metadata before merge.