Uh oh!
There was an error while loading. Please reload this page.
Assets detection and tokens balances controllers - #19
Merged
Conversation
…ntract has tokenOfOwnerByIndex method
Codecov Report
@@ Coverage Diff @@## master #19 +/- ##
======================================
Coverage 100% 100% ======================================
Files 15 18 +3 Lines 694 956 +262 Branches 76 109 +33 ======================================
+ Hits 694 956 +262
Continue to review full report at Codecov.
|
3 tasks
bitpshr
approved these changes
Oct 17, 2018
bitpshr
left a comment
Contributor
There was a problem hiding this comment.
Two minor suggestions, but looks great and should be ready to land.
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| try { | ||
| const contract = this.web3.eth.contract(abiERC20).at(address); | ||
| return await new Promise<typeof BN>((resolve, reject) => { |
Contributor
There was a problem hiding this comment.
Same comment here re: returning the Promise directly.
Suggested change
| returnawaitnewPromise<typeofBN>((resolve,reject)=>{ | |
| returnnewPromise<typeofBN>((resolve,reject)=>{ |
ContributorAuthor
There was a problem hiding this comment.
@bitpshr yeah this is weird, I did this as a workaround for web3/web3.js#1119 since the workaround mentioned there wasn't working. The issue is still open, let me know what you think.
Uh oh!
There was an error while loading. Please reload this page.
Merged
mcmire pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* Improve types and type validation * Fix JsonRpcSuccess type * Add functions to check if a value is a JsonRpcResponse * Fix error message * Add test vectors * Move test.data to fixtures folder * Improve error messages
kanthesha pushed a commit
that referenced
this pull request
Sep 19, 2023
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit
that referenced
this pull request
Sep 22, 2023
v1.0.1 contains two changes that should have been considered semver-major: - Type-interface incompatability with previous version (MetaMask/json-rpc-engine#139) - Introduced dependency `@metamask/json-rpc-engine` indicates a minimum supported Node.js version of 16. This prevents the module from installing on some package manager configurations, like default yarn classic. This will be re-released as v2.0.0.
Mrtenz pushed a commit
that referenced
this pull request
Oct 16, 2025
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
…etaMask#19) * Remove cancelled transaction when new trx with same nonce submitted * fix list concatenation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to support auto detection of assets and also add token balances.
For the second purpose a new
TokenBalancesControllerwas created to poll for balances.Auto detection was achieved adding two new controllers.
AssetsContractController: Only responsibility to interact with contracts of assets through provider. (Probably needs a better name)AssetsDetectionController: Responsible to auto detect new tokens and collectibles. Auto detection is being triggered when user change account or a period of 3 minutes is finished, while user is on mainnet.Assets that are detected are the assets with their respective information in https://github.com/metamask/eth-contract-metadata.
The proposed structure for collectible to be auto detected from eth-contract-metadata,
{ name: string; address: string; symbol?: string; api?: string; collectibles_api?: string; owner_api?: string; collectibles_entry?: string; erc721?: boolean; }name: Asset namesymbol: Asset symbolerc721: Whether it ERC721 assetapi: API URIcollectibles_api: API specific endpoint to get collectibles information, as custom informationowner_api: API specific endpoint to get owner information, as quantity of assets ownedcollectibles_entry: API parameter to get collectibles of owner fromowner_apiURIThe objective of this structure was to provide both compability for new assets and to support current ERC721 standard. There is support for three "types" of collectibles:
Collectibles with API defined on contract-metadata, as Cryptokitties, which only interaction is through its API. In this case, collectibles are being added with custom name and image for each collectible.
Collectibles with ERC721Enumerable interface support, but no support of ERC721Metadata interface. Link to EIP. In this case, if
apiandcollectibles_apiare defined, collectibles are being added with custom information as name and collectible specific image. If not, collectible is being added only with Collectible Identifier.Collectibles with ERC721Enumerable interface and no support of ERC721Metadata interface. Link to EIP. In this case, collectibles are being added with custom name and image for each collectible.