Uh oh!
There was an error while loading. Please reload this page.
Maintain activeCurrency in CurrencyRateController state - #22
Closed
estebanmino wants to merge 1 commit into
Closed
Conversation
3 tasks
bitpshr
reviewed
Nov 13, 2018
bitpshr
left a comment
Contributor
There was a problem hiding this comment.
One comment then this looks good.
| */ | ||
| set currency(currency: string) { | ||
| this.activeCurrency = currency; | ||
| this.update({ currentCurrency: currency }); |
Contributor
There was a problem hiding this comment.
Since currency is now maintained as state, it doesn't need a getter at all. This whole method can go away now (and the associated tests.) Instead, downstream modules would pass in a new (or initial) currency by setting state.
bitpshr
commented
Nov 27, 2018
Contributor
Closing in favor of #30, which includes more related cleanup. |
3 tasks
mcmire pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* 3.0.0 * Update changelog Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit
that referenced
this pull request
Sep 22, 2023
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
* 1.1.0 * Change unreleased in v1.1.0 to added Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Matthew Epps <mepps32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to maintain
activeCurrencyinCurrencyRateControllerin order to persist information incurrentCurrencystate when the controller is disabled and enabled again.