Uh oh!
There was an error while loading. Please reload this page.
CurrencyRatesController: add baseAsset support - #30
Conversation
Codecov Report
@@ Coverage Diff @@## master #30 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 18 18 Lines 889 891 +2 Branches 97 97 =====================================
+ Hits 889 891 +2
Continue to review full report at Codecov.
|
c71b81f to
f93194eComparef93194e to
f3024adCompare| const baseAsset = 'FOO'; | ||
| const controller = new CurrencyRateController({ baseAsset }); | ||
| const mock = stub(window, 'fetch'); | ||
| (window.fetch as SinonStub).returns( |
There was a problem hiding this comment.
Can we use mock here instead of casting window.fetch? mock should have .returns on it, I think.
Also we might be able to use .resolves(x) instead of .returns(Promise.resolve(x)) here.
brunobar79
left a comment
There was a problem hiding this comment.
LGTM! Just one question about deps.
| "human-standard-token-abi": "^2.0.0", | ||
| "isomorphic-fetch": "^2.2.1", | ||
| "percentile": "^1.2.1", | ||
| "uuid": "^3.3.2", |
There was a problem hiding this comment.
I couldn't find where you are using this dep. in this PR
There was a problem hiding this comment.
We were missing it, it's used in TransactionController.
90b9038 to
c9e55e0Compare* 3.0.3 * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
This pull request cleans up
CurrencyRatesControllerand adds support for a new configuration parameter:baseAsset.