Uh oh!
There was an error while loading. Please reload this page.
Update TypeScript - #268
Merged
Merged
Conversation
whymarrhforce-pushed
the
update-typescript
branch
from
September 9, 2020 14:54
9c6c67e to
95ab544Comparewhymarrh
marked this pull request as ready for review
September 9, 2020 15:52
Gudahtt
reviewed
Sep 9, 2020
| */ | ||
| approveMessage(messageParams: PM): Promise<P> { | ||
| this.setMessageStatusApproved(messageParams.metamaskId); | ||
| this.setMessageStatusApproved(messageParams.metamaskId!); |
Member
There was a problem hiding this comment.
Is this always defined 🤔
If we're not sure, perhaps we should ignore this problem for now instead of asserting that it is defined.
ContributorAuthor
There was a problem hiding this comment.
Updated to use a ts-ignore comment
Gudahtt
approved these changes
Sep 9, 2020
Mrtenz pushed a commit
that referenced
this pull request
Oct 16, 2025
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #266
This PR updates the project to the latest version of TypeScript. New in 4.0:[1]