Skip to content

Update TypeScript ESLint packages - #269

Merged
whymarrh merged 1 commit into
MetaMask:developfrom
whymarrh:update-typescript-eslint
Sep 9, 2020
Merged

Update TypeScript ESLint packages#269
whymarrh merged 1 commit into
MetaMask:developfrom
whymarrh:update-typescript-eslint

Conversation

@whymarrh

Copy link
Copy Markdown
Contributor

Prereq for #268

This PR updates the @typescript-eslint/* packages, introducing support for TypeScript 4.

@whymarrh
whymarrh requested a review from a team as a code ownerSeptember 9, 2020 15:44
@whymarrh

Copy link
Copy Markdown
ContributorAuthor

The switch away from object types is in response to the updated ban-types rule:

 45:9 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh
whymarrh merged commit 43bcf3f into MetaMask:developSep 9, 2020
@whymarrh
whymarrh deleted the update-typescript-eslint branch September 9, 2020 15:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@whymarrh@Gudahtt