Skip to content

deps(keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0 - #3779

Closed
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-keyring-controller-16
Closed

deps(keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0#3779
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-keyring-controller-16

Conversation

@legobeat

@legobeatlegobeat commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Explanation

References

Blocking

Changelog

@metamask/keyring-controller

  • CHANGED: Update @metamask/keyring-api from ^2.0.0 to ^3.0.0
  • CHANGED: Update @metamask/eth-keyring-controller from ^17.0.0 to ^17.0.1

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

socket-securityBot commented Jan 12, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@metamask/eth-keyring-controller@17.0.1Transitive: environment, eval, filesystem, network, shell, unsafe+424137 MBbrad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/keyring-api@3.0.0Transitive: environment, eval, filesystem, network, shell, unsafe+414136 MBbrad.decker, danfinlay, gudahtt, ...9 more

🚮 Removed packages:npm/@metamask/eth-keyring-controller@17.0.0

View full report↗︎

@socket-security

socket-securityBot commented Jan 12, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/eth-keyring-controller@17.0.1, npm/@metamask/keyring-api@3.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @legobeat
    legobeat marked this pull request as ready for review January 15, 2024 10:47
    @legobeat
    legobeat requested a review from a team as a code ownerJanuary 15, 2024 10:47
    @legobeatlegobeat added the dependencies Pull requests that update a dependency file label Jan 15, 2024
    @mikesposito

    Copy link
    Copy Markdown
    Member
    @SocketSecurity ignore @metamask/obs-store@9.0.0
    

    gudahtt is a trusted author

    @SocketSecurity ignore @metamask/eth-keyring-controller@16.0.0
    

    v16.0.0 has been published 4 days ago

    @mcmire

    Copy link
    Copy Markdown
    Collaborator

    @mikesposito This is blocked by the fact that keyring-api introduces a circular dependency on this repo, correct?

    @mikesposito

    Copy link
    Copy Markdown
    Member

    @mcmire Exactly, we should fix that in eth-keyring-controller before merging this one

    @mikesposito

    Copy link
    Copy Markdown
    Member

    We should now update to eth-keyring-controller ^17.0.1 directly, but v17 comes with a breaking change related to createNewVaultAndKeychain and createNewVaultAndRestore.

    @legobeat
    legobeatforce-pushed the deps-keyring-controller-16 branch from 48110bd to b38cc16CompareJanuary 22, 2024 12:44
    @legobeat

    legobeat commented Jan 22, 2024

    Copy link
    Copy Markdown
    ContributorAuthor

    We should now update to eth-keyring-controller ^17.0.1 directly, but v17 comes with a breaking change related to createNewVaultAndKeychain and createNewVaultAndRestore.

    …17.0.1
    - @metamask/keyring-api@^2.0.0->^3.0.0
    @legobeat
    legobeatforce-pushed the deps-keyring-controller-16 branch from b38cc16 to cb45a7fCompareJanuary 22, 2024 12:45
    @legobeatlegobeat changed the title deps: @metamask/eth-keyring-controller@^15.1.0->^16.0.0deps*keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0Jan 22, 2024
    @legobeatlegobeat changed the title deps*keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0deps(keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0Jan 22, 2024
    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore npm/@metamask/keyring-api@3.0.0
    @SocketSecurity ignore npm/@metamask/eth-keyring-controller@17.0.1
    

    False-flagged as "unpublished"

    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor

    Due to the requirement in yarn constraints, closing this in favor of #3747

    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @legobeat@mikesposito@mcmire