feat: add methods to support ERC-4337 accounts by danroc · Pull Request #3602 · MetaMask/core

danroc · 2023-12-01T13:50:03Z

Description

Depends on:

This PR adds the following new methods available in the EthKeyring interface:

prepareUserOperation
patchUserOperation
signUserOperation

See the PR in the keyring-api for more details.

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
I've highlighted breaking changes using the "BREAKING" category above as appropriate

socket-security · 2023-12-08T10:24:46Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-keyring-controller@17.0.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+472`	159 MB	metamaskbot
npm/@metamask/eth-snap-keyring@2.1.1	Transitive: environment, eval, filesystem, network, shell, unsafe	`+467`	158 MB	metamaskbot
npm/@metamask/keyring-api@2.0.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+462`	158 MB	metamaskbot
npm/@types/bn.js@5.1.1	None	`+1`	3.54 MB	types
npm/@types/pbkdf2@3.1.0	None	`+1`	3.53 MB	types
npm/@types/secp256k1@4.0.3	None	`+1`	3.54 MB	types

🚮 Removed packages:npm/@endo/env-options@0.1.4, npm/@metamask/approval-controller@0.0.0-use.local, npm/@metamask/base-controller@3.2.3, npm/@metamask/controller-utils@0.0.0-use.local, npm/@metamask/eth-query@3.0.1, npm/@metamask/eth-snap-keyring@2.0.0, npm/@metamask/keyring-api@1.1.0, npm/@metamask/object-multiplex@1.3.0, npm/@metamask/permission-controller@0.0.0-use.local, npm/@metamask/providers@13.1.0, npm/@metamask/snaps-rpc-methods@3.3.0, npm/@metamask/snaps-ui@3.1.0, npm/@metamask/snaps-utils@3.3.0, npm/@types/bn.js@5.1.5, npm/@types/pbkdf2@3.1.2, npm/@types/secp256k1@4.0.6, npm/end-of-stream@1.4.4, npm/ethjs-unit@0.1.6, npm/json-rpc-middleware-stream@4.2.3

View full report↗︎

montelaidev · 2024-01-18T11:08:58Z

@metamaskbot publish-preview

github-actions · 2024-01-18T11:13:30Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
"@metamask-previews/accounts-controller": "7.0.1-preview.228ccaca",
"@metamask-previews/address-book-controller": "3.1.6-preview.228ccaca",
"@metamask-previews/announcement-controller": "5.0.1-preview.228ccaca",
"@metamask-previews/approval-controller": "5.1.1-preview.228ccaca",
"@metamask-previews/assets-controllers": "23.1.0-preview.228ccaca",
"@metamask-previews/base-controller": "4.0.1-preview.228ccaca",
"@metamask-previews/build-utils": "1.0.1-preview.228ccaca",
"@metamask-previews/composable-controller": "5.0.0-preview.228ccaca",
"@metamask-previews/controller-utils": "8.0.1-preview.228ccaca",
"@metamask-previews/ens-controller": "8.0.0-preview.228ccaca",
"@metamask-previews/eth-json-rpc-provider": "2.3.1-preview.228ccaca",
"@metamask-previews/gas-fee-controller": "12.0.0-preview.228ccaca",
"@metamask-previews/json-rpc-engine": "7.3.1-preview.228ccaca",
"@metamask-previews/json-rpc-middleware-stream": "6.0.1-preview.228ccaca",
"@metamask-previews/keyring-controller": "11.0.0-preview.228ccaca",
"@metamask-previews/logging-controller": "2.0.1-preview.228ccaca",
"@metamask-previews/message-manager": "7.3.7-preview.228ccaca",
"@metamask-previews/name-controller": "4.1.0-preview.228ccaca",
"@metamask-previews/network-controller": "17.1.0-preview.228ccaca",
"@metamask-previews/notification-controller": "4.0.1-preview.228ccaca",
"@metamask-previews/permission-controller": "7.1.0-preview.228ccaca",
"@metamask-previews/permission-log-controller": "0.0.0-preview.228ccaca",
"@metamask-previews/phishing-controller": "8.0.1-preview.228ccaca",
"@metamask-previews/polling-controller": "4.0.0-preview.228ccaca",
"@metamask-previews/preferences-controller": "5.0.1-preview.228ccaca",
"@metamask-previews/queued-request-controller": "0.3.0-preview.228ccaca",
"@metamask-previews/rate-limit-controller": "4.0.1-preview.228ccaca",
"@metamask-previews/selected-network-controller": "6.0.0-preview.228ccaca",
"@metamask-previews/signature-controller": "9.0.0-preview.228ccaca",
"@metamask-previews/transaction-controller": "19.0.1-preview.228ccaca",
"@metamask-previews/user-operation-controller": "0.0.0-preview.228ccaca"
}

socket-security · 2024-01-22T10:14:34Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/obs-store@9.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

danroc · 2024-01-22T10:23:28Z

@SocketSecurity ignore npm/@metamask/obs-store@9.0.0

montelaidev

LGTM

…roller-in-sync-with-keyrings * origin/main: chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805) fix: custody keyring name (#3803) chore: update dependencies for `@metamask/accounts-controller` (#3747) fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802) feat: add methods to support ERC-4337 accounts (#3602) feat: add getAccount action to AccountsController (#1892)

Gudahtt · 2024-01-22T15:32:14Z

+ "@lavamoat/allow-scripts": "^2.3.1",
 "@metamask/auto-changelog": "^3.4.4",
 "@metamask/eth-sig-util": "^7.0.1",
- "@metamask/preferences-controller": "^6.0.0",


Hey @danroc, why was this moved from dev dependenices to dependencies? I'm asking because this conflicts with one of my PRs, where this is being removed as a dependency completely.

danroc added the team-accounts label Dec 1, 2023

danroc force-pushed the feature/erc-4337-support branch 2 times, most recently from 0d6fa8d to c36fc6bCompare December 8, 2023 10:18

danroc force-pushed the feature/erc-4337-support branch from 6b56615 to 0442d7dCompare January 9, 2024 14:18

danroc added 15 commits January 22, 2024 10:57

feat: use EthKeyring interface
2b71f31

feat: add UserOperation methods
344b80b

chore: format package.json
3611ca9

fix: hardcode supported account methods in tests
07074a4

chore: enable lcov for test coverage
5f5c795

fix: ignore Snaps dependencies errors
e8d52f8

test: add UserOperation tests
58626dd

chore: update @metamask/keyring-api version to 2.0.0
b9189b3

test: add MockErc4337Keyring import
3449b4b

chore: update keyring-api in package.json files
34af456

chore: remove unused directive
c9db590

chore: add temporary resolution
57a08d3

chore: put ignore error back and await promise
7b98cd4

chore: update eth-keyring-controller to version 17.0.0
8f8c61a

fix: bump eth-keyring-controller and related dependencies
b7789bc

danroc force-pushed the feature/erc-4337-support branch from 228ccac to b7789bcCompare January 22, 2024 10:13

danroc marked this pull request as ready for review January 22, 2024 10:14

danroc requested a review from a team as a code owner January 22, 2024 10:14

danroc self-assigned this Jan 22, 2024

chore: remove skipLibCheck
0e95e80

montelaidev approved these changes Jan 22, 2024
View reviewed changes

danroc merged commit 8a79dc5 into mainJan 22, 2024

danroc deleted the feature/erc-4337-support branch January 22, 2024 10:38

legobeat mentioned this pull request Jan 22, 2024
deps(keyring-controller): @metamask/keyring-api@^2.0.0->^3.0.0 #3779
Closed
3 tasks

Gudahtt reviewed Jan 22, 2024
View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

feat: add methods to support ERC-4337 accounts - #3602

feat: add methods to support ERC-4337 accounts#3602
danroc merged 16 commits into
mainfrom
feature/erc-4337-support

danroc commented Dec 1, 2023•
edited by AlexJupiter
Loading

Uh oh!

socket-securityBot commented Dec 8, 2023•
edited
Loading

Uh oh!

montelaidev commented Jan 18, 2024

Uh oh!

github-actionsBot commented Jan 18, 2024

Uh oh!

socket-securityBot commented Jan 22, 2024•
edited
Loading

Uh oh!

danroc commented Jan 22, 2024

Uh oh!

montelaidev left a comment

Uh oh!

GudahttJan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

danroc commented Dec 1, 2023• edited by AlexJupiter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

socket-securityBot commented Dec 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montelaidev commented Jan 18, 2024

Uh oh!

github-actionsBot commented Jan 18, 2024

Uh oh!

socket-securityBot commented Jan 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next steps

Uh oh!

danroc commented Jan 22, 2024

Uh oh!

montelaidev left a comment

Choose a reason for hiding this comment

Uh oh!

GudahttJan 22, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danroc commented Dec 1, 2023•
edited by AlexJupiter
Loading

socket-securityBot commented Dec 8, 2023•
edited
Loading

socket-securityBot commented Jan 22, 2024•
edited
Loading