Skip to content

fix: custody keyring name - #3803

Merged
montelaidev merged 4 commits into
mainfrom
fix/ap-216/fix-custody-name
Jan 22, 2024
Merged

fix: custody keyring name#3803
montelaidev merged 4 commits into
mainfrom
fix/ap-216/fix-custody-name

Conversation

@montelaidev

Copy link
Copy Markdown
Contributor

Explanation

This PR updates the custody keyring name and removes the need for a patch to be used in the extension client.

References

Changelog

@metamask/keyring-controller

  • UPDATES: The custody keyring type name from Custody to Custody JSONRPC

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidevmontelaidev self-assigned this Jan 22, 2024
@montelaidev
montelaidev requested a review from a team as a code ownerJanuary 22, 2024 06:16
gantunesr
gantunesr previously approved these changes Jan 22, 2024
@gantunesrgantunesr changed the title Fix/ap 216/fix custody namefix: custody keyring nameJan 22, 2024
@montelaidev
montelaidev merged commit ee80823 into mainJan 22, 2024
@montelaidev
montelaidev deleted the fix/ap-216/fix-custody-name branch January 22, 2024 13:17
Gudahtt added a commit that referenced this pull request Jan 22, 2024
…roller-in-sync-with-keyrings
* origin/main:
chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
fix: custody keyring name (#3803)
chore: update dependencies for `@metamask/accounts-controller` (#3747)
fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
feat: add methods to support ERC-4337 accounts (#3602)
feat: add getAccount action to AccountsController (#1892)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@montelaidev@gantunesr@danroc